Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moky88 keyboard #22954

Merged
merged 28 commits into from
Feb 19, 2024
Merged

Add moky88 keyboard #22954

merged 28 commits into from
Feb 19, 2024

Conversation

VertorWang
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 24, 2024
keyboards/moky/moky88/info.json Show resolved Hide resolved
keyboards/moky/moky88/info.json Outdated Show resolved Hide resolved
keyboards/moky/moky88/info.json Outdated Show resolved Hide resolved
keyboards/moky/moky88/moky88.c Outdated Show resolved Hide resolved
keyboards/moky/moky88/config.h Outdated Show resolved Hide resolved
keyboards/moky/moky88/info.json Outdated Show resolved Hide resolved
keyboards/moky/moky88/config.h Outdated Show resolved Hide resolved
keyboards/moky/moky88/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/moky/moky88/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/moky/moky88/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Community Layout support

keyboards/moky/moky88/info.json Outdated Show resolved Hide resolved
keyboards/moky/moky88/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/moky/moky88/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Jan 24, 2024

as of commit a85f947: directory keymaps/default/ is missing a rules.mk file containing ENCODER_MAP_ENABLE = yes

VertorWang and others added 11 commits January 24, 2024 17:57
Delete solid_color

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@VertorWang
Copy link
Contributor Author

add Community Layout support

How do I add community layout support

@dunk2k
Copy link
Contributor

dunk2k commented Jan 25, 2024

add Community Layout support

How do I add community layout support

Already have, when respectively named suggestion was accepted 😉

@waffle87 waffle87 merged commit 672986a into qmk:master Feb 19, 2024
2 checks passed
peepeetee pushed a commit to peepeetee/qmk_firmware that referenced this pull request Mar 12, 2024
* Update

* 代码对齐

* 修改键盘名称

* 增加Readme

* Add copyright notice

* Update keyboards/moky/moky88/info.json

Delete solid_color

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/moky88.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/keymaps/via/keymap.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/keymaps/default/keymap.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/keymaps/via/keymap.c

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Add a key to enter the bootloader, and add instructions to the readme documentation

* delete maintainer

* add default/rules.mk

* Update readme.md

* Update readme.md

---------

Co-authored-by: vertor <zhen.wang@westberrytech.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* Update

* 代码对齐

* 修改键盘名称

* 增加Readme

* Add copyright notice

* Update keyboards/moky/moky88/info.json

Delete solid_color

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/moky88.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/keymaps/via/keymap.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/keymaps/default/keymap.c

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/moky/moky88/info.json

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/keymaps/via/keymap.c

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* Update keyboards/moky/moky88/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Add a key to enter the bootloader, and add instructions to the readme documentation

* delete maintainer

* add default/rules.mk

* Update readme.md

* Update readme.md

---------

Co-authored-by: vertor <zhen.wang@westberrytech.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants