Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD KB19 keyboard #22604

Closed
wants to merge 20 commits into from
Closed

ADD KB19 keyboard #22604

wants to merge 20 commits into from

Conversation

DOIO2022
Copy link
Contributor

@DOIO2022 DOIO2022 commented Dec 4, 2023

Description

Add KB19 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

DOIO2022 and others added 20 commits November 3, 2023 09:58
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 4, 2023
@zvecr zvecr closed this Dec 4, 2023
@zvecr
Copy link
Member

zvecr commented Dec 4, 2023

You should not open new PRs with exactly the same content, in some poor attempt to jump it to the top of the PR queue.

@DOIO2022
Copy link
Contributor Author

DOIO2022 commented Dec 4, 2023

You should not open new PRs with exactly the same content, in some poor attempt to jump it to the top of the PR queue.
@zvecr hi, the pr #22393 is the kb3x keyboard ,but it was blocked so long time , I think it maybe has problems ,so I did this pr #22604. and by the way , if the pr don't have problems, how long can be mergerd? Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants