Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add h101 PCB #22186
add h101 PCB #22186
Changes from 14 commits
33f835a
334d3a5
b225d41
6bbc367
1bba813
a39c9ae
19f2bb1
d468e32
fcd59f5
2ed4500
c8e019b
6d038b6
03996ac
30b85c0
8475758
5e62005
56b1b99
93d573f
15a8cda
5cde839
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This keymap should be removed, as users should just use the
via
keymap and select their layout options within the UI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the maps need to be different due to the matrix assignments, I tried it with the way you described and it didn't work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends what you mean by "didnt work". If its that some matrix positions were not filled in with default values, then the issue is your
LAYOUT_all
does not represent all matrix locations. Other its difficult to guess, but likely an issue with the via config.Duplicating the via keymap does little to resolve the root of the issue and shouldnt be accepted to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this. I was going to have two "via keymaps" one for F12, and one for F13 function rows. each would have a different default mapping due to how I did the matrix. I'm instead just going to supply the F12/F13 VIA keymap files, that'll be easier for customers to figure out