Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootmagic mods covering the case when swapped mods are pressed at the same time (#21320) #21472

Merged
merged 1 commit into from
Jul 8, 2023
Merged

bootmagic mods covering the case when swapped mods are pressed at the same time (#21320) #21472

merged 1 commit into from
Jul 8, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 7, 2023

Description

Reapply #21320 to develop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 7, 2023 15:04
@github-actions github-actions bot added the core label Jul 7, 2023
@tzarc tzarc merged commit f41bc8c into develop Jul 8, 2023
@tzarc tzarc deleted the reapply-21320 branch July 8, 2023 00:15
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@tzarc @nimishgautam @jesperhellberg
bootmagic mods covering the case when swapped mods are pressed at the…
1212dce 
… same time (qmk#21320) (qmk#21472)

Co-authored-by: Nimish Gåtam <nimishg@gmail.com>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@tzarc @nimishgautam @thismarvin
bootmagic mods covering the case when swapped mods are pressed at the…
4d70382 
… same time (qmk#21320) (qmk#21472)

Co-authored-by: Nimish Gåtam <nimishg@gmail.com>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@tzarc @nimishgautam @akeep
bootmagic mods covering the case when swapped mods are pressed at the…
4d9de0f 
… same time (qmk#21320) (qmk#21472)

Co-authored-by: Nimish Gåtam <nimishg@gmail.com>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@tzarc @nimishgautam @csolje
bootmagic mods covering the case when swapped mods are pressed at the…
1e9a1b2 
… same time (qmk#21320) (qmk#21472)

Co-authored-by: Nimish Gåtam <nimishg@gmail.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@tzarc @nimishgautam @autoferrit
bootmagic mods covering the case when swapped mods are pressed at the…
0aaae29 
… same time (qmk#21320) (qmk#21472)

Co-authored-by: Nimish Gåtam <nimishg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @nimishgautam