Update adamtabrams keymap #21344

adamtabrams · 2023-06-22T23:32:18Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* handle mod tap for keys on the same side * update config values * remove some tapping force hold * update keymap and config

keyboards/planck/keymaps/adamtabrams/config.h

dunk2k · 2023-06-26T10:22:59Z

CI build failures showing error: 'RGBLED_NUM' undeclared here (not in a function) is because your keymap has specified "rgblight" as enabled but hasn't specified corresponding pin and number of leds (rgblight driver would be good also)

keyboards/planck/keymaps/adamtabrams/rules.mk

adamtabrams · 2023-06-27T00:39:19Z

https://github.com/qmk/qmk_firmware/pull/21344/checks?check_run_id=14573543723

note: include '<math.h>'

Seems a bit strange that I would need to include a library I have no use for to make my keymap compatible with a hardware revision I'm not using.

fauxpark · 2023-06-27T00:54:42Z

You can move your keymap under your particular revision folder; it will then only be built for that rev.

adamtabrams · 2023-06-28T16:43:18Z

I noticed that QMK CI Build only runs if the latest commit for the PR has modified keymap.c. So a user can make it look like all the checks are passing by making a new commit that only modifies other files. Just FYI.

adamtabrams · 2023-06-28T18:07:18Z

keyboards/planck/rev7/matrix.c:26:40: note: include '<math.h>' or provide a declaration of 'log'

If rev7 relies on the log function from math.h shouldn't that be imported in the matrix.c file?

dunk2k · 2023-06-29T09:23:40Z

If rev7 relies on the log function from math.h shouldn't that be imported in the matrix.c file?

I'm in agreement that the build failure for rev7 should be resolved at keyboard level, not keymap level.

sigprof · 2023-06-29T10:53:36Z

#21408 should fix the failure for planck/rev7.

sigprof · 2023-07-03T19:49:49Z

keyboards/planck/keymaps/adamtabrams/keymap.c

+bool is_left_key(int row) {
+    return row < 4 || row == 7;
+}
+
+bool is_right_key(int row) {
+    return row > 2;
+}


This part is actually specific to planck rev6 (and rev7, which apparently has the same matrix). And technically the handling of rows 3 and 7 is wrong (row 3 is used for both far left and far right keys on the bottom row, and row 7 is used by the central 6 keys of the bottom row).

sigprof · 2023-07-03T19:53:04Z

keyboards/planck/keymaps/adamtabrams/keymap.c

+    clear_mods();
+    for (int i = 0; i < num_mods; i++) {
+        if (counts[i] == 0) {
+            tap_code16(mods[i]);


This effectively does

Suggested change

tap_code16(mods[i]);

tap_code(QK_MOD_TAP_GET_TAP_KEYCODE(mods[i]));

However, that peculiarity of the tap_code16() behavior (keycodes outside of the QK_BASIC…QK_MODS_MAX range are truncated to the low byte) does not seem to be documented anywhere.

github-actions · 2023-10-14T01:48:24Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2023-11-13T01:49:51Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

adamtabrams · 2024-03-05T03:52:39Z

@drashna @fauxpark I noticed this never go merged in. What changes do I need to make for that to happen?

zvecr · 2024-03-05T04:10:41Z

What changes do I need to make for that to happen?

It wont be merged #22724.

Unfortunately QMK has changed its stance on accepting user keymaps to the repository.

qmk/qmk_firmware is no longer accepting PRs for keymaps other than for manufacturer-supported keymaps. User keymap workflow has been documented here for several years. This change is to progressively reduce the maintenance burden on the project, and to allow us to focus on the core features of QMK.

QMK Firmware now officially supports storing user keymaps outside of the normal QMK Firmware repository, allowing users to maintain their own keymaps without having to fork, modify, and maintain a copy of QMK Firmware themselves.

While we appreciate the time that was taken on this PR, hopefully you understand we are closing it, so that QMK can improve in the long term.

adamtabrams · 2024-03-05T04:17:52Z

QMK Firmware now officially supports storing user keymaps outside of the normal QMK Firmware repository,

@zvecr Thanks for the quick response. And I'm glad to hear this!

adamtabrams and others added 30 commits February 19, 2021 19:55

create keymap

9c91257

small style updates

3a2ab0d

fix name of constant

0d3cbc3

move tapping force function to keymap file

3b13241

fix transparent keycode

d06c4a6

optimize keymap

be111f7

improve docs

40d84c9

escape backslashes in readme

62f060e

improve mouse and tap-hold configs

4fb08c7

add key for restoring normal layer

b3b7533

optimize hold-tap, scroll speed, and layer toggle

5ee05ac

prevent escape when command and space are pressed

7407607

improve custom GUIGESC keycode

e3db07c

change modifier layout

2996499

add right gui and fix escape

436052e

move escape to left thumb

fcfd360

swap equal and hyphen for normal layer

60e3e6b

rearrange lower row symbols

4297ef3

change placement of symbols

f135dd5

move CURSOR to left and add arrows keys to right

fba9296

fix readme

6fc235f

fix accidental alt

dab643f

add timer to number layer

68230d3

add colemak layer

8789466

add macros, improve custom keys, and hold space for number layer

654b8a5

add homerow mods

f8b3747

improve layout for each layer

fdd8eee

add simple layer and improve symbol layout

05808de

increase tapping term and improve simple layout

12df187

Merge remote-tracking branch 'upstream/master' into adam4-plus-colemak

33b558b

adamtabrams added 2 commits June 22, 2023 13:49

Merge branch 'qmk:master' into master

adb7522

update keymap and config (#1)

20bd5eb

* handle mod tap for keys on the same side * update config values * remove some tapping force hold * update keymap and config

github-actions bot added the keymap label Jun 22, 2023

fix mod tap for numspace

702628d

drashna approved these changes Jun 24, 2023

View reviewed changes

drashna requested a review from a team June 24, 2023 07:50

fauxpark requested changes Jun 24, 2023

View reviewed changes

keyboards/planck/keymaps/adamtabrams/config.h Show resolved Hide resolved

adamtabrams added 3 commits June 26, 2023 18:53

fix overflow bug

6abe5b6

try relying on rev6 default rules

ef30558

ignore other tap toggle configs

2c1d4e3

adamtabrams commented Jun 27, 2023

View reviewed changes

keyboards/planck/keymaps/adamtabrams/rules.mk Outdated Show resolved Hide resolved

adamtabrams added 2 commits June 28, 2023 10:49

update rules

511b1b3

add debugging

82facc8

sigprof mentioned this pull request Jun 29, 2023

planck/rev7: Fix build without AUDIO_ENABLE #21408

Merged

14 tasks

drashna approved these changes Jul 3, 2023

View reviewed changes

sigprof reviewed Jul 3, 2023

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 14, 2023

github-actions bot closed this Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update adamtabrams keymap #21344

Update adamtabrams keymap #21344

adamtabrams commented Jun 22, 2023

dunk2k commented Jun 26, 2023 •

edited

Loading

adamtabrams commented Jun 27, 2023

fauxpark commented Jun 27, 2023

adamtabrams commented Jun 28, 2023

adamtabrams commented Jun 28, 2023

dunk2k commented Jun 29, 2023 •

edited

Loading

sigprof commented Jun 29, 2023

sigprof Jul 3, 2023

sigprof Jul 3, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Nov 13, 2023

adamtabrams commented Mar 5, 2024 •

edited

Loading

zvecr commented Mar 5, 2024 •

edited

Loading

adamtabrams commented Mar 5, 2024

	tap_code16(mods[i]);
	tap_code(QK_MOD_TAP_GET_TAP_KEYCODE(mods[i]));

Update adamtabrams keymap #21344

Update adamtabrams keymap #21344

Conversation

adamtabrams commented Jun 22, 2023

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

dunk2k commented Jun 26, 2023 • edited Loading

adamtabrams commented Jun 27, 2023

fauxpark commented Jun 27, 2023

adamtabrams commented Jun 28, 2023

adamtabrams commented Jun 28, 2023

dunk2k commented Jun 29, 2023 • edited Loading

sigprof commented Jun 29, 2023

sigprof Jul 3, 2023

Choose a reason for hiding this comment

sigprof Jul 3, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2023

github-actions bot commented Nov 13, 2023

adamtabrams commented Mar 5, 2024 • edited Loading

zvecr commented Mar 5, 2024 • edited Loading

adamtabrams commented Mar 5, 2024

dunk2k commented Jun 26, 2023 •

edited

Loading

dunk2k commented Jun 29, 2023 •

edited

Loading

adamtabrams commented Mar 5, 2024 •

edited

Loading

zvecr commented Mar 5, 2024 •

edited

Loading