Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controller] Add ModelH STM32 controller firmware #20578

Closed
wants to merge 11 commits into from
Closed

[Controller] Add ModelH STM32 controller firmware #20578

wants to merge 11 commits into from

Conversation

medoix
Copy link

@medoix medoix commented Apr 26, 2023 •
edited by tzarc
Loading

Description

Looking to merge the ModelH config and keymaps into QMK master. This device is an STM32 controller designed as a drop in replacement for the IBM Model M Keyboard series to support USB Type-B and QMK.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added invalid pr_checklist_pending Needs changes as per the PR checklist labels Apr 26, 2023
drashna
drashna requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checklist needs to be reviewed.

Most of the config.h settings are outdated, etc.

keyboards/modelh/chconf.h Outdated Show resolved Hide resolved
keyboards/modelh/halconf.h Outdated Show resolved Hide resolved
keyboards/modelh/mcuconf.h Outdated Show resolved Hide resolved
@medoix medoix requested a review from drashna April 29, 2023 08:06
@lesshonor lesshonor mentioned this pull request Apr 29, 2023
Merged
14 tasks
@drashna
Copy link
Member

drashna commented May 2, 2023

identical to #20625

@sc-steven
Copy link

identical to #20625

@drashna Yes it appears someone else raised a PR a couple of days after this one. Happy for either to be selected.

@medoix
Copy link
Author

medoix commented Jun 25, 2023

Closing in favor of this PR #20625

@medoix medoix closed this Jun 25, 2023
@medoix medoix deleted the modelh branch September 12, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
invalid keyboard keymap pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medoix @drashna @sc-steven @tzarc