-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added native Miryoku support #20366
Added native Miryoku support #20366
Conversation
- added LAYOUT_split_3x5_3 to following variants: - 4x5 - 4x5_5 - 4x6 - 4x6_5 - 5x6 - 5x6_5 - removed keymap Manna-harbour_miryoku from all variants where present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These layouts do not work with the data-driven direction keyboards are being moved in. All keys in a layout must have exactly one matrix position, no more, no less:
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
☒ Invalid LAYOUT macro in keyboards/handwired/dactyl_manuform/4x5/4x5.h: Key XXX in macro LAYOUT_split_3x5_3 has multiple matrix positions ([3, 0], [3, 1], [3, 2], [4, 0], [4, 1], [4, 2], [4, 3], [8, 0], [8, 2], [9, 0], [9, 1], [9, 2], [9, 3])
modified: keyboards/handwired/dactyl_manuform/4x5/4x5.h modified: keyboards/handwired/dactyl_manuform/4x5_5/4x5_5.h modified: keyboards/handwired/dactyl_manuform/4x6/4x6.h modified: keyboards/handwired/dactyl_manuform/4x6_5/4x6_5.h modified: keyboards/handwired/dactyl_manuform/5x6/5x6.h modified: keyboards/handwired/dactyl_manuform/5x6_5/5x6_5.h
Aim is to update/add 'via' keymaps and modernise to data driven format. In the interim, ethos is to make incremental changes to dactyl manuform keyboard directory(s). |
modified: keyboards/handwired/dactyl_manuform/4x5/4x5.c modified: keyboards/handwired/dactyl_manuform/4x5/4x5.h modified: keyboards/handwired/dactyl_manuform/4x6/4x6.c modified: keyboards/handwired/dactyl_manuform/4x6/4x6.h modified: keyboards/handwired/dactyl_manuform/4x6_5/4x6_5.c modified: keyboards/handwired/dactyl_manuform/4x6_5/4x6_5.h modified: keyboards/handwired/dactyl_manuform/5x6/5x6.c modified: keyboards/handwired/dactyl_manuform/5x6/5x6.h modified: keyboards/handwired/dactyl_manuform/5x6_5/5x6_5.c modified: keyboards/handwired/dactyl_manuform/5x6_5/5x6_5.h
Changes made in #20365 supersede changes made in this PR |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist