Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added aristides_2862 controller support for Unicomp keyboards. #20260

Closed
wants to merge 5 commits into from
Closed

Added aristides_2862 controller support for Unicomp keyboards. #20260

wants to merge 5 commits into from

Conversation

purdeaandrei
Copy link
Contributor

@purdeaandrei purdeaandrei commented Mar 26, 2023 •
edited
Loading

Description

This PR depends on:
EDIT: no more dependencies!
#20259 - depends on changes to the outer info.json in this PR
#20104 - to get rid of lint errors

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    • only tested that it compiles, and correctly enumerates on USB.

@purdeaandrei purdeaandrei changed the title Added aristides_2862 controller support for Unicomp (and IBM) keyboards. Added aristides_2862 controller support for Unicomp keyboards. Mar 26, 2023
@purdeaandrei purdeaandrei force-pushed the f_add_support_for_aristides_2862_controller branch from a90970e to 221f247 Compare April 8, 2023 05:09
@purdeaandrei
Copy link
Contributor Author

This PR doesn't have any more dependencies (One has been merged, and the other one has been worked around).

@purdeaandrei
Added aristides_2862 controller support for Unicomp keyboards.
a249ed8
@purdeaandrei
Define cols and rows to make compilation warning go away
59bf539
@purdeaandrei
Unicomp keyboards: improved image links
969c4d1 
Some images moved to imgur.
Added some notes explaining how some of the images are not exactly accurate.
@purdeaandrei
Moved non-layout information from the outer json into the inner json,…
9f5f32b 
… feels like a better place for this, even if for now it's the same for both supported controllers
@purdeaandrei
Increase debounce to 10ms
1d05491
@purdeaandrei purdeaandrei force-pushed the f_add_support_for_aristides_2862_controller branch from cfe1a42 to 1d05491 Compare June 19, 2023 00:09
drashna
drashna reviewed Jul 4, 2023
View reviewed changes
keyboards/unicomp/spacesaver_m_pre_2013/aristides_2862/rules.mk
Comment on lines +11 to +12
ARISTIDES_COMMON_FILES=../../../unicomp/classic_ultracl_post_2013/aristides_2862
SRC += $(ARISTIDES_COMMON_FILES)/matrix.c $(ARISTIDES_COMMON_FILES)/aristides_2862.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, these files should be moved to a common folder and included from there

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 19, 2023
drashna
drashna requested changes Aug 30, 2023
View reviewed changes
keyboards/unicomp/spacesaver_m_post_2013/aristides_2862/aristides_2862.c
Comment on lines +19 to +29
void keyboard_post_init_kb(void)
{
// Led pins:
// GP4 is the left-most led, normally Num Lock, but on Spacesaver M it's Caps Lock. Configured in info.json
writePin(GP3, 1);
setPinOutput(GP3); // middle led, always off on Spacesaver M

writePin(GP2, 1);
setPinOutput(GP2); // right-most led, normally Scroll Lock, but on Spacesaver M indicates function layer
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void keyboard_post_init_kb(void)
{
// Led pins:
// GP4 is the left-most led, normally Num Lock, but on Spacesaver M it's Caps Lock. Configured in info.json
writePin(GP3, 1);
setPinOutput(GP3); // middle led, always off on Spacesaver M
writePin(GP2, 1);
setPinOutput(GP2); // right-most led, normally Scroll Lock, but on Spacesaver M indicates function layer
}
void keyboard_post_init_kb(void) {
// Led pins:
// GP4 is the left-most led, normally Num Lock, but on Spacesaver M it's Caps Lock. Configured in info.json
writePin(GP3, 1);
setPinOutput(GP3); // middle led, always off on Spacesaver M
writePin(GP2, 1);
setPinOutput(GP2); // right-most led, normally Scroll Lock, but on Spacesaver M indicates function layer
keyboard_post_init_user();
}

keyboards/unicomp/classic_ultracl_post_2013/aristides_2862/rules.mk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most/all of this should be moved to the info.json. qmk info -f json can assist with that.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 31, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
keyboard stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purdeaandrei @drashna