Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for wildcard filtering in qmk mass-compile #19625

Merged
merged 3 commits into from
Jan 18, 2023
+8 −4
Merged

Allow for wildcard filtering in qmk mass-compile #19625

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5f9a62
Allow for wildcard filtering in `qmk mass-compile`
tzarc Jan 18, 2023
c487ca6
Formatting.
tzarc Jan 18, 2023
0cbfe74
`format-python` and `pytest` don't agree.
tzarc Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/python/qmk/cli/mass_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

This will compile everything in parallel, for testing purposes.
"""
import fnmatch
import logging
import multiprocessing
import os
Expand Down Expand Up @@ -58,7 +59,7 @@ def _load_keymap_info(keyboard, keymap):
arg_only=True,
action='append',
default=[],
help="Filter the list of keyboards based on the supplied value in rules.mk. Matches info.json structure, and accepts the format 'features.rgblight=true'. May be passed multiple times, all filters need to match."
help="Filter the list of keyboards based on the supplied value in rules.mk. Matches info.json structure, and accepts the format 'features.rgblight=true'. May be passed multiple times, all filters need to match. Value may include wildcards such as '*' and '?'."
)
@cli.argument('-km', '--keymap', type=str, default='default', help="The keymap name to build. Default is 'default'.")
@cli.argument('-e', '--env', arg_only=True, action='append', default=[], help="Set a variable to be passed to make. May be passed multiple times.")
Expand Down Expand Up @@ -102,11 +103,12 @@ def mass_compile(cli):
cli.log.info(f'Filtering on condition ("{key}" == "{value}")...')

def _make_filter(k, v):
expr = fnmatch.translate(v)
rule = re.compile(expr, re.IGNORECASE)
def f(e):
lhs = e[2].get(k)
lhs = str(False if lhs is None else lhs).lower()
rhs = str(v).lower()
return lhs == rhs
lhs = str(False if lhs is None else lhs)
return rule.search(lhs) is not None

return f

Expand Down