[Keyboard] Stop LED1 from flashing on layer change #19427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
requested changes
Dec 26, 2022
drashna
approved these changes
Jan 1, 2023
fauxpark
approved these changes
Jan 4, 2023
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
barrettclark
added a commit
to barrettclark/qmk_firmware
that referenced
this pull request
Mar 6, 2023
* upstream/master: (1825 commits) A comma was missing (qmk#19507) Bump anothrNick/github-tag-action from 1.56.0 to 1.57.0 (qmk#19502) Add SapuSeven MacroPad12 (qmk#19466) feat(kprepublic/bm60hsrgb_poker): update carlosala keymap (qmk#19426) [Keyboard] Stop LED1 from flashing on layer change (qmk#19427) Allow for specifying the number of symbols to output. (qmk#19497) Add `qmk mass-compile`, which intends to supercede `qmk multibuild` whilst providing support for filtering as per data-driven definitions. (qmk#18971) Bump anothrNick/github-tag-action from 1.55.0 to 1.56.0 (qmk#19494) Fix github URL for the atreyu maintainer. (qmk#19476) adpenrose/akemipad fixes (qmk#19477) [Keymap] Add Neo2-based keymap for Planck keyboard (qmk#19173) [Keyboard] Add community layout support to Piantor (qmk#19455) Keyboard/fix work louder micro (qmk#18968) Add docs to cover recent LAYOUT_all lint checks (qmk#19393) WSL `qmk flash firmware.bin` workaround (qmk#19434) CLI flashers should allow files outside qmk_firmware folder (qmk#19454) [Keyboard] Add Quarkeys Z60, reorganized keyboard file directory (qmk#19404) Add KB30 keyboard (qmk#19395) Atreyu rev2 (qmk#19443) Fixes unicode_map declaration example (qmk#19450) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LED1 is activated by keypress and then deactivated by the layer change code. This causes LED1 to flash momentarily.
Description
This PR removed the deactivation of LED1 on layer change so that it stays on and does not flash.
Types of Changes
Issues Fixed or Closed by This PR
Checklist