Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 #19195

Merged
merged 10 commits into from
Dec 30, 2022
Merged

[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 #19195

merged 10 commits into from
Dec 30, 2022

Conversation

jasonj2232
Copy link
Contributor

@jasonj2232 jasonj2232 commented Nov 29, 2022 •
edited
Loading

Description

Added support for a new keyboard - Ishi 80 Mk0

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added dependencies keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 29, 2022
waffle87
waffle87 requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • keyboards/argo_works/ishi/80/mk0_avr/rules.mk should match templates/keyboard/rules.mk
  • There are submodule commits that need to be reverted.

keyboards/argo_works/ishi/80/mk0_avr/info.json Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr/info.json Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr/info.json Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/info.json Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/keymaps/bongocat/keymap.c Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/info.json Outdated Show resolved Hide resolved
@jasonj2232
Reverted submodules to QMK master version and fixed Git issues
811899b
@jasonj2232
Implemened changes requested in PR review.
d1beaaf 
Added keyboard level OLED definition for mk0_avr_extra firmware.

Common Changes:

*Renamed 'LAYOUT_ishi_80_mk0' to LAYOUT
*Removed import<stdio.h> from all keymaps
*Changed processor and board defintions to development board definitions
@jasonj2232
Added pin compatibility information for use in converters
f8a8dae
@jasonj2232 jasonj2232 requested review from drashna and waffle87 and removed request for drashna and waffle87 November 30, 2022 23:52
@jasonj2232
Copy link
Contributor Author

Hey @waffle87 and @drashna, would you please take a look at this again? Many thanks!

waffle87
waffle87 requested changes Dec 20, 2022
View reviewed changes
keyboards/argo_works/ishi/80/mk0_avr_extra/mk0_avr_extra.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_avr_extra/rules.mk Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/info.json Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/keymaps/bongocat/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/mk0_avr_extra.c Outdated Show resolved Hide resolved
keyboards/argo_works/ishi/80/mk0_rp2040_extra/readme.md Outdated Show resolved Hide resolved
@jasonj2232 jasonj2232 requested review from waffle87 and removed request for drashna December 20, 2022 23:32
@drashna drashna requested review from a team and removed request for waffle87 December 23, 2022 07:02
@tzarc tzarc merged commit 6b50b1b into qmk:master Dec 30, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@jasonj2232
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
51ed813
@jasonj2232 jasonj2232 mentioned this pull request Dec 31, 2022
Merged
6 tasks
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
@jasonj2232 @jasonisgraham
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
4188feb
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@jasonj2232 @omikronik
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
b96f5a9
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@jasonj2232 @ideas32
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
93f4f04
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 12, 2023
@jasonj2232 @jasonisgraham
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
7ac7917
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 15, 2023
@jasonj2232 @jasonisgraham
[Keyboard] Added support for a new keyboard - Ishi 80 Mk0 (qmk#19195)
5aa051a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonj2232 @drashna @tzarc @waffle87