Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychron Q3 Layout Touch-Up #18696

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Keychron Q3 Layout Touch-Up #18696

merged 6 commits into from
Oct 13, 2022

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Oct 13, 2022

Description

Was hoping to get this in on the keyboard merge, but missed the window.

  • standardize the layout macro names for the ANSI and ISO boards
    • Q3 ANSI: rename LAYOUT_ansi_87 to LAYOUT_tkl_ansi
    • Q3 ANSI with Encoder: rename LAYOUT_ansi_88 to LAYOUT_tkl_f13_ansi
    • Q3 ISO: rename LAYOUT_iso_88 to LAYOUT_tkl_iso
    • Q3 ISO with Encoder: rename LAYOUT_iso_89 to LAYOUT_tkl_f13_iso
  • fix Configurator key sizes on the JIS boards
    • Q3 JIS (double 2u Backspaces):
      keychron_q3_jis_default
    • Q3 JIS with Encoder (overlap on Spacebar's left):
      keychron_q3_jis_encoder_default

cc @lalalademaxiya1 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 13, 2022
@noroadsleft noroadsleft requested a review from a team October 13, 2022 07:02
@tzarc tzarc merged commit d5b9081 into qmk:master Oct 13, 2022
@noroadsleft noroadsleft deleted the rf/keychron_q3 branch October 13, 2022 07:33
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@whyfuture
Copy link

Couldn't figure out how to setup rotary rotation settings in QMK. Also F3/F4 is not mapped for Mac by default

@noroadsleft
Copy link
Member Author

@whyfuture,

Couldn't figure out how to setup rotary rotation settings in QMK.

The rotary encoder should already be programmed (Volume control normally, and RGB Brightness in the function layer) if you're using firmware compiled from this repository.

Also F3/F4 is not mapped for Mac by default

This was requested by us in #16912 (review) – QMK has tooling which uses the default keymap as a base when a user wants to create their own keymap. It's for this reason that we like the default keymaps to be void of any overly advanced functionality.

aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants