Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct configuration for supersplit #18646

Closed
wants to merge 3 commits into from
Closed

Correct configuration for supersplit #18646

wants to merge 3 commits into from

Conversation

tarneaux
Copy link
Contributor

@tarneaux tarneaux commented Oct 8, 2022

Description

The configuration for the supersplit as in #18611 was actually wrong. I tested it today with the two micro controllers and with the correct wiring, and there was no communication, the main elite-c would send 2 key presses (from both halves) when it detected an electric contact on its matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

With the supersplit there was no communication between the controllers
and one of them had the keys on both halves.
Added supersplit.c and superplit.h
Removed the pin config from info.json and moved it to config.h
keyboards/supersplit/config.h Outdated Show resolved Hide resolved
keyboards/supersplit/info.json Show resolved Hide resolved
keyboards/supersplit/supersplit.c Outdated Show resolved Hide resolved
keyboards/supersplit/supersplit.h Outdated Show resolved Hide resolved
keyboards/supersplit/info.json Outdated Show resolved Hide resolved
@tarneaux tarneaux requested a review from zvecr November 1, 2022 10:06
@tarneaux tarneaux closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants