-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linworks FAve 87H Layout Refactor #18497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No logic change. - use QMK-native keycode aliases - update keycode grid alignment
Move position K3C (right half of split Backspace) to the number row.
noroadsleft
added
enhancement
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
labels
Sep 27, 2022
drashna
approved these changes
Sep 27, 2022
fauxpark
approved these changes
Sep 27, 2022
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Oct 2, 2022
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No, you aren't seeing double – there are two of these.
Arranges the
LAYOUT
macro (now namedLAYOUT_tkl_ansi_split_bs
) physically, and adds a non-split Backspace layout. Enables Community Layouts support.With this change, the keycode for the right half of a split Backspace is now on the number row, instead of home row. Affected out-of-tree keymaps should be modified accordingly.
cc @ToastyStoemp (keyboard maintainer)
Types of Changes
Checklist