Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linworks FAve 87H Layout Refactor #18497

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Conversation

noroadsleft
Copy link
Member

Description

No, you aren't seeing double – there are two of these.

Arranges the LAYOUT macro (now named LAYOUT_tkl_ansi_split_bs) physically, and adds a non-split Backspace layout. Enables Community Layouts support.

With this change, the keycode for the right half of a split Backspace is now on the number row, instead of home row. Affected out-of-tree keymaps should be modified accordingly.

cc @ToastyStoemp (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 27, 2022
@noroadsleft noroadsleft requested a review from a team September 27, 2022 01:09
@drashna drashna requested a review from a team September 27, 2022 03:29
@drashna drashna merged commit 492c34f into qmk:master Sep 27, 2022
@noroadsleft noroadsleft deleted the rf/linworks_fave87h branch September 27, 2022 21:28
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants