Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Update Work Louder keyboards #18109

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[Keyboard] Update Work Louder keyboards #18109

merged 1 commit into from
Aug 19, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 19, 2022

Description

  • Added equally hacky, but more maintainable RGB code
  • Update to use Encoder Map instead of hacky "encoder actions"
  • Updated config to remove hacky config settings
  • Increment product ID for VIA detection (because it can't/won't detect product version changes)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 19, 2022 23:07
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 19, 2022
@drashna drashna merged commit 39f0fb7 into qmk:master Aug 19, 2022
@drashna drashna deleted the keyboard/update_work_louder_boards branch August 19, 2022 23:49
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@drashna @imhoffman
[Keyboard] Update Work Louder keyboards (qmk#18109)
3783015
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@drashna @nolanseaton
[Keyboard] Update Work Louder keyboards (qmk#18109)
eb25d4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark