Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Miryoku keymap for Hillside family #18087

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Add Miryoku keymap for Hillside family #18087

merged 1 commit into from
Aug 20, 2022

Conversation

mssdvd
Copy link

@mssdvd mssdvd commented Aug 17, 2022

Description

This PR adds the Miryoku keymap for the Hillside familily.

I did not add a README since the other Miryoku mappings I checked have none. Is that OK?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mssdvd mssdvd changed the title [Keymap] Add Miryoku keymap for Hillside family Add Miryoku keymap for Hillside family Aug 17, 2022
@drashna drashna requested a review from a team August 20, 2022 01:55
@drashna drashna merged commit c9120ea into qmk:master Aug 20, 2022
@mssdvd mssdvd deleted the hillside-miryoku branch August 20, 2022 06:59
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@mssdvd @imhoffman
[Keymap] Add Miryoku keymap for Hillside family (qmk#18087)
49d1ae8
@mssdvd
Copy link
Author

mssdvd commented Aug 21, 2022

I didn't add a keymap for the 0.1 which has been renamed to 48 in a PR merged into develop. Which branch should I base the new PR on?

@mmccoyd
Copy link
Contributor

mmccoyd commented Aug 22, 2022

I'd wait five days till develop gets merged into master. Then add the PR to master.
Thanks for adding these keymaps!!

nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@mssdvd @nolanseaton
[Keymap] Add Miryoku keymap for Hillside family (qmk#18087)
66d47ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mssdvd @mmccoyd @drashna @fauxpark