Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add aliceh66 pianoforte #18081

Merged
merged 21 commits into from
Aug 20, 2022
Merged

[Keyboard] Add aliceh66 pianoforte #18081

merged 21 commits into from
Aug 20, 2022

Conversation

AliceH66
Copy link

@AliceH66 AliceH66 commented Aug 17, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@AliceH66
QMK Files
bf6af85 
QMK Files for firmware
@AliceH66
Merge branch 'qmk:master' into json1
14c436b
@AliceH66
via coloring
b2ff4b1 
Added necessary colouring for VIA
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 17, 2022
drashna
drashna requested changes Aug 17, 2022
View reviewed changes
keyboards/aliceh66/pianoforte/config.h Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/info.json Show resolved Hide resolved
keyboards/aliceh66/pianoforte/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/keymaps/vial/config.h Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/keymaps/vial/keymap.c Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/keymaps/vial/config.h Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/keymaps/vial/pianoforte_hs/pianoforte_hs.json Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/rules.mk Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Aug 17, 2022
AliceH66 and others added 9 commits August 17, 2022 17:04
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte/keymaps/via/rules.mk
56d937f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte/rules.mk
1a7aa44 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte_hs/rules.mk
3d1280d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte/config.h
0d86316 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte/info.json
fd515a0 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte_hs/keymaps/via/rules.mk
b955fd5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte_hs/config.h
deb8b99 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte_hs/info.json
cab9d40 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66
Vial files
f870e2c 
Files removed for QMK.
@AliceH66 AliceH66 requested a review from drashna August 17, 2022 21:55
@AliceH66
Copy link
Author

I committed to the suggestions and removed the VIAL files, I believe that should be it?

@drashna drashna changed the title New keyboard for the QMK Master [Keyboard] Add aliceh66 pianoforte Aug 18, 2022
drashna
drashna requested changes Aug 18, 2022
View reviewed changes
keyboards/aliceh66/pianoforte/config.h Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/config.h Outdated Show resolved Hide resolved
AliceH66 and others added 2 commits August 18, 2022 01:12
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte/config.h
d74d228 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 @drashna
Update keyboards/aliceh66/pianoforte_hs/config.h
fb098de 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@AliceH66 AliceH66 requested a review from drashna August 18, 2022 05:46
@drashna drashna requested a review from a team August 18, 2022 16:52
@drashna drashna removed the pr_checklist_pending Needs changes as per the PR checklist label Aug 18, 2022
@AliceH66
.c files
36c57bb 
missing
fauxpark
fauxpark requested changes Aug 18, 2022
View reviewed changes
keyboards/aliceh66/pianoforte_hs/info.json Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/info.json Outdated Show resolved Hide resolved
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte/info.json
2ed8490 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte_hs/info.json
5d45226 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 AliceH66 requested a review from fauxpark August 19, 2022 16:09
fauxpark
fauxpark requested changes Aug 19, 2022
View reviewed changes
keyboards/aliceh66/pianoforte/readme.md Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte/rules.mk Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/readme.md Outdated Show resolved Hide resolved
keyboards/aliceh66/pianoforte_hs/rules.mk Outdated Show resolved Hide resolved
AliceH66 and others added 4 commits August 19, 2022 18:27
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte/readme.md
78ff26b 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte/rules.mk
bfd8bb7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte_hs/readme.md
1e220e4 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 @fauxpark
Update keyboards/aliceh66/pianoforte_hs/rules.mk
269712d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 AliceH66 requested a review from fauxpark August 20, 2022 01:35
@drashna drashna merged commit 85831fc into qmk:master Aug 20, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@AliceH66 @drashna
@fauxpark @imhoffman
[Keyboard] Add aliceh66 pianoforte (qmk#18081)
497af55 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@AliceH66 AliceH66 deleted the json1 branch August 20, 2022 20:26
@AliceH66 AliceH66 mentioned this pull request Aug 20, 2022
Merged
6 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@AliceH66 @drashna
@fauxpark @nolanseaton
[Keyboard] Add aliceh66 pianoforte (qmk#18081)
70bd50b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AliceH66 @drashna @fauxpark @zvecr