Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the GHS.JEM #17340

Merged
merged 17 commits into from
Sep 26, 2022
Merged

Add the GHS.JEM #17340

merged 17 commits into from
Sep 26, 2022

Conversation

ramonimbao
Copy link
Contributor

Description

Add the GHS.JEM

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 9, 2022
drashna
drashna requested changes Jul 26, 2022
View reviewed changes
keyboards/ghs/jem/config.h Outdated Show resolved Hide resolved
keyboards/ghs/jem/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 26, 2022 07:26
fauxpark
fauxpark requested changes Jul 26, 2022
View reviewed changes
keyboards/ghs/jem/rules.mk Outdated Show resolved Hide resolved
keyboards/ghs/jem/rules.mk Outdated Show resolved Hide resolved
@ramonimbao
Copy link
Contributor Author

Hello, can I request for a recheck of this? I've finished migrating everything to the new data-driven way of QMK.

@ramonimbao ramonimbao requested a review from fauxpark September 2, 2022 11:26
fauxpark
fauxpark requested changes Sep 2, 2022
View reviewed changes
keyboards/ghs/jem/soldered/config.h Outdated Show resolved Hide resolved
keyboards/ghs/jem/hotswap_ansi/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/ghs/jem/hotswap_ansi/config.h Outdated Show resolved Hide resolved
keyboards/ghs/jem/soldered/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/ghs/jem/info.json Show resolved Hide resolved
keyboards/ghs/jem/hotswap_ansi/info.json Outdated Show resolved Hide resolved
keyboards/ghs/jem/soldered/info.json Outdated Show resolved Hide resolved
ramonimbao and others added 4 commits September 2, 2022 19:31
@ramonimbao @fauxpark
Update keyboards/ghs/jem/info.json
478aab2 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ramonimbao @fauxpark
Update keyboards/ghs/jem/hotswap_ansi/info.json
c26a02f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ramonimbao @fauxpark
Update keyboards/ghs/jem/soldered/info.json
f8d675d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@ramonimbao
Delete unnecessary files
3806aa7
@drashna drashna merged commit 7a5a99b into qmk:master Sep 26, 2022
@ramonimbao ramonimbao mentioned this pull request Sep 26, 2022
Merged
6 tasks
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@ramonimbao @drashna
@fauxpark @tacahiroy
[Keyboard] Add GHS.JEM (qmk#17340)
6e7aaab 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@ramonimbao @drashna @fauxpark
[Keyboard] Add GHS.JEM (qmk#17340)
e5b52ac 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
ramonimbao added a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@ramonimbao @drashna @fauxpark
[Keyboard] Add GHS.JEM (qmk#17340)
31ab049 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@ramonimbao @drashna
@fauxpark @nolanseaton
[Keyboard] Add GHS.JEM (qmk#17340)
ff92eb8 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramonimbao @drashna @fauxpark