Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Anne Pro 2 bootloader & flashing #16548

Closed
wants to merge 1 commit into from
Closed

Conversation

bwisn
Copy link

@bwisn bwisn commented Mar 6, 2022

Description

Added Anne Pro 2 bootlader and flashing.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 6, 2022
@bwisn bwisn mentioned this pull request Mar 6, 2022
14 tasks
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code wont actually function correctly and will produce

Invalid API data: blah: bootloader: 'annepro2' is not one of ['atmel-dfu', 'bootloadhid', 'bootloadHID', 'custom', 'caterina', 'halfkay', 'kiibohd', 'lufa-dfu', 'lufa-ms', 'md-boot', 'qmk-dfu', 'qmk-hid', 'stm32-dfu', 'stm32duino', 'gd32v-dfu', 'wb32-dfu', 'unknown', 'usbasploader', 'USBasp', 'tinyuf2']

However there are higher level issues:

  • platforms containing keyboard specific code is conceptually wrong
    • linking and invocation of keyboard level code in bootloader_jump
    • board file checks in flash.mk

Given this will have limited exposure, it should be implemented as
BOOTLOADER = custom and PROGRAM_CMD = annepro2_tools $(BUILD_DIR)/$(TARGET).bin at the keyboard level.

annepro2.c would contain the bootloader_jump implementation.

@bwisn
Copy link
Author

bwisn commented Mar 6, 2022

This code wont actually function correctly and will produce

Invalid API data: blah: bootloader: 'annepro2' is not one of ['atmel-dfu', 'bootloadhid', 'bootloadHID', 'custom', 'caterina', 'halfkay', 'kiibohd', 'lufa-dfu', 'lufa-ms', 'md-boot', 'qmk-dfu', 'qmk-hid', 'stm32-dfu', 'stm32duino', 'gd32v-dfu', 'wb32-dfu', 'unknown', 'usbasploader', 'USBasp', 'tinyuf2']

However there are higher level issues:

  • platforms containing keyboard specific code is conceptually wrong

    • linking and invocation of keyboard level code in bootloader_jump
    • board file checks in flash.mk

Given this will have limited exposure, it should be implemented as BOOTLOADER = custom and PROGRAM_CMD = annepro2_tools $(BUILD_DIR)/$(TARGET).bin at the keyboard level.

annepro2.c would contain the bootloader_jump implementation.

Fixed this in #14385, can I close this PR?

@zvecr
Copy link
Member

zvecr commented Mar 7, 2022

No longer required

@zvecr zvecr closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants