Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boardsource The Mark 65 Touch-Up and Layout Additions #16270

Merged
merged 9 commits into from
Feb 8, 2022
Merged

Boardsource The Mark 65 Touch-Up and Layout Additions #16270

merged 9 commits into from
Feb 8, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • update keyboard header file
    • use QMK 3-character notation for matrix positions
    • add matrix diagram
  • refactors the reference keymaps
    • convert tabs to spaces
    • use four-space indent
    • grid align keycodes
    • remove extra line breaks
    • add layer indexes to via keymap
  • add LAYOUT_ansi_split_bs_space and LAYOUT_iso_split_bs_space layout macros with reference keymaps
  • edit maintainer field in info.json

cc @daysgobye @boardsource (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
the_mark.h: use ____ for KC_NO
be163de
@noroadsleft
the_mark.h: number matrix positions electrically
280c518 
`K300` and `K301` has misleading identifiers - `K300` was on column 1 and `K301` on column 0.
@noroadsleft
the_mark.h: use QMK 3-character notation
d6cc4e9
@noroadsleft
the_mark.h: add matrix diagram
71d8359
@noroadsleft
refactor reference keymaps
9af5316 
- convert tabs to spaces
- use four-space indent
- grid align keycodes
- remove extra line breaks
- add layer indexes to `via` keymap
@noroadsleft
info.json: apply friendly formatting
807c40d
@noroadsleft
add LAYOUT_ansi_split_bs_space
33ce819 
Includes reference keymap.
@noroadsleft
add LAYOUT_iso_split_bs_space
e4f7e5f 
Includes reference keymap.
@noroadsleft
info.json: edit maintainer value
7bc248e 
There is a Boardsource GitHub account, but knowing the user who maintains it is helpful.
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 8, 2022
@noroadsleft noroadsleft requested a review from a team February 8, 2022 00:19
@noroadsleft
Copy link
Member Author

noroadsleft commented Feb 8, 2022 •
edited
Loading

I lost track of a review I had assigned to myself in #11571 (authored by @jsanchez0x; apologies for that). This PR supersedes that one.

@noroadsleft noroadsleft mentioned this pull request Feb 8, 2022
Closed
14 tasks
@noroadsleft noroadsleft merged commit f3aa5db into qmk:master Feb 8, 2022
@noroadsleft noroadsleft deleted the cf/boardsource_the_mark branch February 8, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark