Fix RESET key not working on Ergodox EZ keyboard.

[Rovanion]

A declaration of controller chip was missing in the config.h.

[jackhumbert]

I'm not sure this is needed - no other projects that I can find define this anywhere. It may be added in at compilation.

[aspickard]

+1 Fixes the issue for me

[jackhumbert]

This is interesting - your bootloader.c is unmodified, and you're calling bootloader_jump(), right?

[jackhumbert]

To bring over other comments, it looks like the referenced __AVR_ATmega32U4__ is commented out with #if 0 here - is anyone else seeing things differently?

[aspickard]

I just updated my repo to the newest master and did a clean make (without these changes) and everything worked fine for me. May have been fixed in another commit. 🍺

[jackhumbert]

Ahh - @alcesleo, could you weigh in here?

[DidierLoiseau]

For the record, the if 0 was introduced in 4d64fd8; the file was later moved, in commit a074364.

[jackhumbert]

@aspickard do you know what commit you were on when making these changes? Maybe we can track down the commit that fixed/changed things.

[aspickard]

9814343 I was a bit behind :X

[Rovanion]

Perhaps I should try using the reset key against an unmodified master when I get home again to see if the RESET button actually works on master nowadays? It could be that I was on an old revision too when I picked up on the issue.

[DidierLoiseau]

I just tested it too and it works for me… kind of.

In fact, the reset key does not work immediately after reloading the firmware with the teensy button. It only works after I unplug and re-plug the keyboard. After that, it works all the time… until I use the teensy button again.

I think the first time I tried to add a reset key (back when @alcesleo created #112), I didn't try to unplug the keyboard.

I'm currently on d33681a without modifications outside my own keymap.

[Rovanion]

The results are in and I'm terribly sorry to have wasted everybody's time: Turns out that the RESET button works with the current origin/master (on commit 11c591c) as well as with my local master which I must have updated at some point between noticing the issue and checking into the thread at #112.

It's too bad that the RESET button did work on my local master, because if it hadn't we could have gotten a span of commits during which the feature was fixed. Oh well.

[aspickard]

I can confirm the same behavior that @DidierLoiseau reports - if I use the Teensy button, then I can't use the software reset unless I unplug and replug the keyboard.

[Rovanion]

Can confirm the same behavior here too, same as what @DidierLoiseau and @aspickard are describing.

[Rovanion]

Well this PR should be closed and replaced with an issue on the topic since the code attached doesn't fix the issue at hand.

I went ahead and opened Issue #164 for this purpose.

[ezuk]

Thank you, Rovanion!

On 25 February 2016 at 03:26, Rovanion Luckey notifications@github.com
wrote:

Well this PR should be closed and replaced with an issue on the topic
since the code attached doesn't fix the issue at hand.

I went ahead and opened Issue #164
#164 for this purpose.

—
Reply to this email directly or view it on GitHub
#162 (comment)
.