Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @davidphilipbarr 's boards into /dpb #16111

Closed
wants to merge 1 commit into from
Closed

Conversation

peepeetee
Copy link
Contributor

Description

At this point in my series of board move PRs, I've started to move boards where I cannot reach the makers beforehand, and have to contact them via the PR itself.

This PR is made without contacting(or failing at contacting) @davidphilipbarr first, so it would need them to approve it for it to go in.

As there was no prior communication before this PR, I have to ask a few questions:

  • Is the folder name satisfactory?
  • Did I leave anything out?
  • Did I include anything I shouldn't have included?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Copy link
Contributor Author

I might have made an egregious mistake ripping ferris sweep out of the ferris folder. discuss and show me the error of my ways

@filterpaper
Copy link
Contributor

filterpaper commented Jan 30, 2022

Please do not make this change. It will hurt the discovery of sweep. That PCB known to the community as the Ferris Sweep and is an iteration of Ferris.

I'm the maintainer of both macro3 and cradio. If it helps, macro3 maintainer can be me so you will not be obliged to store them into the same folder.

@peepeetee peepeetee closed this Jan 30, 2022
@peepeetee
Copy link
Contributor Author

Please do not make this change. It will hurt the discovery of sweep. That PCB known to the community as the Ferris Sweep and is an iteration of Ferris.

I'm the maintainer of both macro3 and cradio. If it helps, macro3 maintainer can be me so you will not be obliged to store them into the same folder.

Got it, thanks! closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants