Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IGNORE_MOD_TAP_INTERRUPT_PER_KEY in favour of HOLD_ON_OTHER_KEY_PRESS_PER_KEY #15741

Merged
merged 16 commits into from
Dec 13, 2022
+224 −515
Merged

Remove IGNORE_MOD_TAP_INTERRUPT_PER_KEY in favour of HOLD_ON_OTHER_KEY_PRESS_PER_KEY #15741

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c438a6a
!get_ignore_mod_tap_interrupt → get_hold_on_other_key_press
precondition Aug 3, 2022
03bf0f9
Remove IGNORE_MOD_TAP_INTERRUPT_PER_KEY from data files
precondition Oct 24, 2022
dfbd0e4
Remove I_M_T_I_P_K* refs from japanese docs
precondition Mar 19, 2022
85cded3
Remove I_M_T_I_P_K* refs from english docs and update H_O_O_K_P*
precondition Mar 19, 2022
9f8e243
tap_mod_tap_key_while_mod_tap_key_is_held → tap_a_mod_tap_key_while_a…
precondition Mar 19, 2022
dcda4a6
Delete ignore_mod_tap_interrupt tests folder
precondition Apr 13, 2022
c4d8503
Delete permissive_hold_ignore_mod_tap_interrupt/
precondition Apr 13, 2022
4901014
Flag IGNORE_MOD_TAP_INTERRUPT_PER_KEY as invalid in lint checks
precondition Jun 18, 2022
9050d21
Flag IGNORE_MOD_TAP_INTERRUPT as deprecated in lint
precondition Aug 3, 2022
e25f36f
Backwards compatibility with defunct `get_ignore_mod_tap_interrupt`.
precondition May 3, 2022
cc5a570
Message announcing deprecation of IGNORE_MOD_TAP_INTERRUPT
precondition Aug 3, 2022
04bf58e
Replace auto shift's ternary from hell by a bool `is_hold_on_interrupt`
precondition Aug 3, 2022
11fa40d
Reword message to emphasize changes in the *default* behavior of MTs
precondition Nov 28, 2022
694e593
Rename “Illustration” section by “Comparison”
precondition Dec 12, 2022
8d91044
More explanations on using `get_hold_on…` to obtain ignore-interrupt
precondition Dec 12, 2022
478d8a5
Add changelog for #15741
precondition Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tap_mod_tap_key_while_mod_tap_key_is_held → tap_a_mod_tap_key_while_a… 
…nother_mod_tap_key_is_held
@precondition
precondition committed Dec 12, 2022

Verified

This commit was signed with the committer’s verified signature.
rithviknishad Rithvik Nishad
SSH Key Fingerprint: ynEGbldHmMroZjzegC4ExcML0fh+tjr73wRWki+kq5c
Verified
Learn about vigilant mode
commit 9f8e2431755879ea19534ce802cb1b343ad02572
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/default_mod_tap/config.h
View file
Original file line number Diff line number Diff line change
@@ -18,4 +18,4 @@

#include "test_common.h"

#define IGNORE_MOD_TAP_INTERRUPT
#define IGNORE_MOD_TAP_INTERRUPT
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/default_mod_tap/test_tap_hold.cpp
View file
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ TEST_F(DefaultTapHold, tap_regular_key_while_mod_tap_key_is_held) {
testing::Mock::VerifyAndClearExpectations(&driver);
}

TEST_F(DefaultTapHold, tap_mod_tap_key_while_mod_tap_key_is_held) {
TEST_F(DefaultTapHold, tap_a_mod_tap_key_while_another_mod_tap_key_is_held) {
TestDriver driver;
InSequence s;
auto first_mod_tap_hold_key = KeymapKey(0, 1, 0, SFT_T(KC_P));
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/ignore_mod_tap_interrupt/config.h
View file
Original file line number Diff line number Diff line change
@@ -18,4 +18,4 @@

#include "test_common.h"

#define IGNORE_MOD_TAP_INTERRUPT
#define IGNORE_MOD_TAP_INTERRUPT
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/permissive_hold/test_tap_hold.cpp
View file
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@ TEST_F(PermissiveHold, tap_regular_key_while_mod_tap_key_is_held) {
testing::Mock::VerifyAndClearExpectations(&driver);
}

TEST_F(PermissiveHold, tap_mod_tap_key_while_mod_tap_key_is_held) {
TEST_F(PermissiveHold, tap_a_mod_tap_key_while_another_mod_tap_key_is_held) {
TestDriver driver;
InSequence s;
auto first_mod_tap_hold_key = KeymapKey(0, 1, 0, SFT_T(KC_P));
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/permissive_hold_ignore_mod_tap_interrupt/config.h
View file
Original file line number Diff line number Diff line change
@@ -19,4 +19,4 @@
#include "test_common.h"

#define IGNORE_MOD_TAP_INTERRUPT
#define PERMISSIVE_HOLD
#define PERMISSIVE_HOLD
2 changes: 1 addition & 1 deletion tests/tap_hold_configurations/permissive_hold_ignore_mod_tap_interrupt/test_tap_hold.cpp
View file
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_regular_key_while_mod_tap_key_i
testing::Mock::VerifyAndClearExpectations(&driver);
}

TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_mod_tap_key_while_mod_tap_key_is_held) {
TEST_F(PermissiveHold_IgnoreModTapInterrupt, tap_a_mod_tap_key_while_another_mod_tap_key_is_held) {
TestDriver driver;
InSequence s;
auto first_mod_tap_hold_key = KeymapKey(0, 1, 0, SFT_T(KC_P));