Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]English docs bugfixes included in @epicskandar's #14924 #15471

Closed
wants to merge 4 commits into from

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Dec 14, 2021

Description

Part of size reduction for #14924 to make it easier to merge

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

docs/driver_installation_zadig.md Outdated Show resolved Hide resolved
docs/driver_installation_zadig.md Outdated Show resolved Hide resolved
docs/driver_installation_zadig.md Outdated Show resolved Hide resolved
@@ -109,7 +109,7 @@ Before opening a pull request, you can preview your changes if you have set up t

or if you only have Python 3 installed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this part should be removed altogether, as the QMK CLI has since become more and more of a required component.

Copy link
Contributor Author

@peepeetee peepeetee Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently I had to use this, and I found this particular bit of information quite useful

peepeetee and others added 3 commits December 14, 2021 15:13
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@peepeetee peepeetee changed the title English docs bugfixes included in @epicskandar's #14924 [Docs]English docs bugfixes included in @epicskandar's #14924 Dec 14, 2021
@peepeetee peepeetee requested a review from fauxpark December 14, 2021 08:34
@peepeetee peepeetee closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants