Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bm60v2_poker #15001

Closed
wants to merge 27 commits into from
Closed

add bm60v2_poker #15001

wants to merge 27 commits into from

Conversation

bdtc123
Copy link

@bdtc123 bdtc123 commented Nov 1, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 1, 2021
sigprof
sigprof requested changes Nov 1, 2021
View reviewed changes
keyboards/bm60v2_poker/bm60v2_poker.c Show resolved Hide resolved
keyboards/bm60v2_poker/bm60v2_poker.c Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/bm60v2_poker.c Show resolved Hide resolved
keyboards/bm60v2_poker/bm60v2_poker.h Show resolved Hide resolved
keyboards/bm60v2_poker/config.h Show resolved Hide resolved
keyboards/bm60v2_poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/rules.mk Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/config.h Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/config.h Outdated Show resolved Hide resolved
bdtc123 and others added 23 commits November 2, 2021 10:33
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/rules.mk
5b170c6 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/rules.mk
32af580 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/rules.mk
a2366a2 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/rules.mk
07b542d 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/keymaps/via/keymap.c
f84a06d 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/bm60v2_poker.c
52bf529 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/bm60v2_poker.h
4e6fbb9 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/config.h
4a7b2ad 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/config.h
4bc665d 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/config.h
5e16004 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/config.h
7bc76d7 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/info.json
dcf8834 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/bm60v2_poker.c
f123d89 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/keymaps/via/keymap.c
e871e06 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/keymaps/default/keymap.c
89a1353 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123
Update bm60v2_poker.c
87fcef3
@bdtc123
Update bm60v2_poker.h
b5674f0
@bdtc123
Update keymap.c
5fd95c5
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/keymaps/via/keymap.c
1159754 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/keymaps/default/keymap.c
7ae8bfe 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123
Update keymap.c
758d2ca
@bdtc123
Update keymap.c
7b125b6
@bdtc123 @sigprof
Update keyboards/bm60v2_poker/config.h
84aadb6 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@bdtc123 bdtc123 requested a review from sigprof November 4, 2021 02:06
drashna
drashna requested changes Nov 5, 2021
View reviewed changes
keyboards/bm60v2_poker/config.h Show resolved Hide resolved
keyboards/bm60v2_poker/config.h Outdated Show resolved Hide resolved
keyboards/bm60v2_poker/rules.mk Outdated Show resolved Hide resolved
bdtc123 and others added 3 commits November 5, 2021 10:42
@bdtc123 @drashna
Update keyboards/bm60v2_poker/config.h
7e362f0 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bdtc123 @drashna
Update keyboards/bm60v2_poker/rules.mk
bd79e66 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bdtc123
Update config.h
6a69eb6
@bdtc123 bdtc123 requested a review from drashna November 5, 2021 04:07
@peepeetee
Copy link
Contributor

Take a look at my #15040, which concerns bm60poker
see if you can target develop and move this to bm60poker/rev2, or wait until next breaking change

@peepeetee peepeetee mentioned this pull request Nov 7, 2021
Merged
14 tasks
@bdtc123
Copy link
Author

bdtc123 commented Nov 7, 2021

我的#15040，它与 bm60poker 相关， 您是否可以将开发目标移至 bm60poker/rev2，或者下次看看重大变化

看看我的#15040，它与 bm60poker 相关， 看看您是否可以将开发目标移至 bm60poker/rev2，或者等到下一次重大更改

Take a look at my #15040, which concerns bm60poker see if you can target develop and move this to bm60poker/rev2, or wait until next breaking change

Ok，may i have your email address?

@peepeetee
Copy link
Contributor

peepeetee commented Nov 7, 2021 •
edited
Loading

我的#15040，它与 bm60poker 相关， 您是否可以将开发目标移至 bm60poker/rev2，或者下次看看重大变化

看看我的#15040，它与 bm60poker 相关， 看看您是否可以将开发目标移至 bm60poker/rev2，或者等到下一次重大更改

Take a look at my #15040, which concerns bm60poker see if you can target develop and move this to bm60poker/rev2, or wait until next breaking change

Ok，may i have your email address?

8行(
看我profile啊
要不我加你qq

@peepeetee peepeetee mentioned this pull request Nov 10, 2021
Merged
14 tasks
drashna pushed a commit that referenced this pull request Dec 25, 2021
@peepeetee @fauxpark
[Keyboard] Add bm60hsrgb_poker/rev2, a continuation of #15001 (#15103)
53996a7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@stale
Copy link

stale bot commented Jan 3, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@peepeetee
Copy link
Contributor

As I've mentioned in the description of #15103, after a discussion with @bdtc123, we decided to have me take over this PR and reincarnate it as #15103, which is already merged. This PR should be able to be safely closed now.

@tzarc tzarc closed this Jan 5, 2022
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@peepeetee @fauxpark @ryphon
[Keyboard] Add bm60hsrgb_poker/rev2, a continuation of qmk#15001 (qmk…
8f3d190 
…#15103)

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof Awaiting requested review from sigprof

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
awaiting changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdtc123 @peepeetee @sigprof @drashna @tzarc