Adding the Ploopy Thumb #14668

ploopyco · 2021-10-01T22:21:01Z

Added an implementation for the upcoming Ploopy Thumb.

Description

Just a bit of configuration stuff. Nothing new or groundbreaking; most of the code is a straight duplicate from the Ploopy Classic (keyboards/ploopyco/trackball).

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/ploopyco/trackball_thumb/rules.mk

keyboards/ploopyco/trackball_thumb/keymaps/drag_scroll/keymap.c

keyboards/ploopyco/trackball_thumb/readme.md

keyboards/ploopyco/trackball_thumb/rules.mk

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

keyboards/ploopyco/trackball_thumb/trackball_thumb.h

fauxpark

.noci file can be deleted, as Travis isn't running anymore.

keyboards/ploopyco/trackball_thumb/rules.mk

kevinlekiller · 2021-12-10T00:59:39Z

I'm having an issue where the up / down axis of the ball is reversed when building a firmware using this PR. The left / right axis is fine.

The default keymap also doesn't work properly on Linux (haven't tried other operating systems).

The default keymap is KC_BTN4, DPI_CONFIG, KC_BTN1, KC_BTN3, KC_BTN2, KC_BTN5

That puts the DPI on left side small lower button, the back button on the left side small top button and the forward button on the 3rd rightmost button.

This works as intended : KC_BTN5, KC_BTN4, KC_BTN1, KC_BTN3, KC_BTN2, DPI_CONFIG

kevinlekiller · 2021-12-10T01:46:50Z

Setting mouse_report.y to -mouse_report.y in pointing_device_task_kb() fixes the inverted trackball y axis, although I've not tested if it interferes with the drag scroll conditional block since I'm not using that.

drashna

Setting mouse_report.y to -mouse_report.y in pointing_device_task_kb() fixes the inverted trackball y axis, although I've not tested if it interferes with the drag scroll conditional block since I'm not using that.

Sounds like it needs POINTING_DEVICE_INVERT_X defined in the keyboard's config.h file then.

keyboards/ploopyco/trackball_thumb/config.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>

ploopyco · 2021-12-14T20:37:52Z

Will squash...this is getting a bit out of hand.

drashna · 2021-12-14T20:45:29Z

Will squash...this is getting a bit out of hand.

No need, we squash when merging, so won't matter either way.

keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

keyboards/ploopyco/trackball_thumb/readme.md

keyboards/ploopyco/trackball_thumb/rev1_001/config.h

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

keyboards/ploopyco/trackball_thumb/trackball_thumb.h

Lenbok · 2021-12-24T05:45:02Z

Trying to build this PR and it's not happy - what am I doing wrong here (I haven't even got to making changes)?

$ git describe
0.15.0-126-gdd28d4c103
$ make ploopyco/trackball_thumb/rev1_001:default
QMK Firmware 0.15.6
Making ploopyco/trackball_thumb/rev1_001 with keymap default

avr-gcc (GCC) 5.4.0
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/ploopyco/opt_encoder.c                                                         [OK]
Compiling: keyboards/ploopyco/trackball_thumb/trackball_thumb.c                                     [OK]
Compiling: keyboards/ploopyco/trackball_thumb/keymaps/default/keymap.c                              [OK]
Compiling: quantum/quantum.c                                                                        [OK]
Compiling: quantum/send_string.c                                                                    [OK]
Compiling: quantum/bitwise.c                                                                        [OK]
Compiling: quantum/led.c                                                                            [OK]
Compiling: quantum/action.c                                                                         [OK]
Compiling: quantum/action_layer.c                                                                   [OK]
Compiling: quantum/action_macro.c                                                                   [OK]
Compiling: quantum/action_tapping.c                                                                 [OK]
Compiling: quantum/action_util.c                                                                    [OK]
Compiling: quantum/eeconfig.c                                                                       [OK]
Compiling: quantum/keyboard.c                                                                       [OK]
Compiling: quantum/keymap_common.c                                                                  [OK]
Compiling: quantum/keycode_config.c                                                                 [OK]
Compiling: quantum/sync_timer.c                                                                     [OK]
Compiling: quantum/logging/debug.c                                                                  [OK]
Compiling: quantum/logging/sendchar.c                                                               [OK]
Compiling: quantum/bootmagic/bootmagic_lite.c                                                       [OK]
Compiling: quantum/bootmagic/magic.c                                                                [OK]
Compiling: quantum/matrix_common.c                                                                  [OK]
Compiling: quantum/matrix.c                                                                         [OK]
Compiling: quantum/debounce/sym_defer_g.c                                                           [OK]
Compiling: quantum/main.c                                                                           [OK]
Compiling: quantum/mousekey.c                                                                       [OK]
Compiling: quantum/pointing_device.c                                                                [OK]
Compiling: quantum/pointing_device_drivers.c                                                        [OK]
Compiling: drivers/sensors/pmw3360.c                                                                [OK]
Compiling: quantum/process_keycode/process_magic.c                                                  [OK]
Compiling: quantum/process_keycode/process_grave_esc.c                                              [OK]
Compiling: quantum/process_keycode/process_space_cadet.c                                            [OK]
Compiling: platforms/avr/drivers/analog.c                                                           [OK]
Archiving: .build/obj_ploopyco_trackball_thumb_rev1_001_default/analog.o                            [OK]
Compiling: platforms/avr/drivers/spi_master.c                                                       [OK]
Archiving: .build/obj_ploopyco_trackball_thumb_rev1_001_default/spi_master.o                        [OK]
Assembling: platforms/avr/xprintf.S                                                                 [OK]
Compiling: platforms/avr/printf.c                                                                   [OK]
Compiling: tmk_core/protocol/host.c                                                                 [OK]
Compiling: tmk_core/protocol/report.c                                                               [OK]
Compiling: tmk_core/protocol/usb_device_state.c                                                     [OK]
Compiling: tmk_core/protocol/usb_util.c                                                             [OK]
Compiling: platforms/avr/platform.c                                                                 [OK]
Compiling: platforms/avr/suspend.c                                                                  [OK]
Compiling: platforms/avr/timer.c                                                                    [OK]
Compiling: platforms/avr/bootloader.c                                                               [OK]
Compiling: tmk_core/protocol/lufa/lufa.c                                                            [OK]
Compiling: tmk_core/protocol/usb_descriptor.c                                                       [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Class/Common/HIDParser.c                                       [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/Device_AVR8.c                                        [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/EndpointStream_AVR8.c                                [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/Endpoint_AVR8.c                                      [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/Host_AVR8.c                                          [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/PipeStream_AVR8.c                                    [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/Pipe_AVR8.c                                          [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/USBController_AVR8.c                                 [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/AVR8/USBInterrupt_AVR8.c                                  [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/ConfigDescriptors.c                                       [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/DeviceStandardReq.c                                       [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/Events.c                                                  [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/HostStandardReq.c                                         [OK]
Compiling: lib/lufa/LUFA/Drivers/USB/Core/USBTask.c                                                 [OK]
Compiling: tmk_core/protocol/lufa/usb_util.c                                                        [OK]
Linking: .build/ploopyco_trackball_thumb_rev1_001_default.elf                                       [ERRORS]
 |
 | .build/obj_ploopyco_trackball_thumb_rev1_001_default/quantum/keyboard.o: In function `keyboard_init':
 | /home2/len/dev/qmk_firmware/quantum/keyboard.c:357: undefined reference to `encoder_init'
 | .build/obj_ploopyco_trackball_thumb_rev1_001_default/quantum/keyboard.o: In function `keyboard_task':
 | /home2/len/dev/qmk_firmware/quantum/keyboard.c:456: undefined reference to `encoder_read'
 | collect2: error: ld returned 1 exit status
 |
make[1]: *** [tmk_core/rules.mk:365: .build/ploopyco_trackball_thumb_rev1_001_default.elf] Error 1
Make finished with errors
make: *** [Makefile:478: ploopyco/trackball_thumb/rev1_001:default] Error 1

Lenbok · 2021-12-24T19:48:11Z

Looks like the most recent commit (dd28d4c) broke it, as the previous commit builds just fine for me. Shouldn't CI have picked that up?

I found all of the DPI settings too sensitive for my liking, and have seen other reports in reddit like this, so perhaps it's worth adding another value or two at the lower end as part of this PR.

drashna · 2021-12-24T20:31:13Z

Sorry, that was my bad. I have pushed a fix for it.

fauxpark · 2021-12-25T00:16:15Z

Shouldn't CI have picked that up?

We don't have CI anymore, unfortunately. travis-ci.org is defunct, and the replacement doesn't really work for our needs.

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Nick Brassel <nick@tzarc.org>

fhanrath

I'm not sure if this is the correct place for this, but I own one of the devices and thought I'd be able to contribute my findings.

If you prefer an issue in your fork, I'll happily move my comments there.

fhanrath · 2022-01-18T18:28:05Z

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

+#    define OPT_THRES 150  // (0-1024) 	Threshold for actication
+#endif
+#ifndef OPT_SCALE
+#    define OPT_SCALE 1  // Multiplier for wheel


OPT_SCALE doesn't seem to do anything right now. Is this meant as a placeholder?

Same goes for OPT_THRES.

the scale used to do something, but that has changed, andt he code needs to be cleaned up (all of the ploopy devices need to be)

fhanrath · 2022-01-18T18:46:58Z

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

+#ifdef PLOOPY_DRAGSCROLL_FIXED
+        pointing_device_set_cpi(is_drag_scroll ? PLOOPY_DRAGSCROLL_DPI : dpi_array[keyboard_config.dpi_config]);
+#else
+        pointing_device_set_cpi(is_drag_scroll ? (dpi_array[keyboard_config.dpi_config] * PLOOPY_DRAGSCROLL_MULTIPLIER) : dpi_array[keyboard_config.dpi_config]);


I don't recognize any difference in speed while dragscrolling. Whatever values I set for PLOOPY_DRAGSCROLL_FIXED, PLOOPY_DRAGSCROLL_DPI or PLOOPY_DRAGSCROLL_MULTIPLIER, the dragscroll speed always seems to be the same.

Is this fixed?

No.
But I was able to integrate the changes from https://gist.github.com/patm1987/4ee78e8727bb4c5a1bbd5f2279b4e79d
into my Fork

Look at the _dragscroll_accumulator_x and _dragscroll_accumulator_y variables and how they are used.

This way I was able to set the dragscroll speed to my liking.

I'd be up to create a pull request to ploopyco if wanted. But I don't think the current state (of my changes) is remotely production ready, so I'd have to put in some work to make it cleaner and configurable for the user.

stale · 2022-04-16T08:33:36Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboards/ploopyco/trackball_thumb/config.h

keyboards/ploopyco/trackball_thumb/trackball_thumb.c

github-actions · 2022-07-23T02:17:10Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna · 2022-07-28T21:23:39Z

@ploopyco would you mind if I take over this PR?

drashna · 2022-08-30T03:39:33Z

closing in favor of #18214

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 1, 2021

drashna approved these changes Oct 2, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved

drashna requested a review from a team October 2, 2021 01:59

fauxpark requested changes Oct 2, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/rules.mk Show resolved Hide resolved

ibash approved these changes Oct 21, 2021

View reviewed changes

drashna requested review from fauxpark and a team October 23, 2021 06:09

drashna reviewed Nov 29, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/keymaps/drag_scroll/keymap.c Show resolved Hide resolved

drashna requested changes Nov 29, 2021

View reviewed changes

ploopyco requested a review from drashna December 7, 2021 13:04

fauxpark reviewed Dec 7, 2021

View reviewed changes

fauxpark requested changes Dec 7, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/rules.mk Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved

drashna self-assigned this Dec 8, 2021

drashna requested changes Dec 10, 2021

View reviewed changes

drashna reviewed Dec 10, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/config.h Show resolved Hide resolved

ploopyco and others added 11 commits December 14, 2021 20:30

thumb firmware, working

aa6001b

thumb button fixes

58e1135

fixed doco

bda4177

fixed layout for info.json

9da13d1

Update keyboards/ploopyco/trackball_thumb/rules.mk

9edf243

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/ploopyco/trackball_thumb/rules.mk

5a81848

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/ploopyco/trackball_thumb/rules.mk

812b566

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/ploopyco/trackball_thumb/readme.md

5f85435

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/ploopyco/trackball_thumb/rules.mk

c01ec15

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

d52f531

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

db49d79

Co-authored-by: Drashna Jaelre <drashna@live.com>

drashna approved these changes Dec 14, 2021

View reviewed changes

fixed the inverted pointer issue; everything is tested and looks okay

88f8d3d

ploopyco requested a review from fauxpark December 15, 2021 19:40

fauxpark requested changes Dec 16, 2021

View reviewed changes

keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved

Update keyboards/ploopyco/trackball_thumb/rules.mk

dd28d4c

Co-authored-by: Ryan <fauxpark@gmail.com>

drashna requested a review from fauxpark December 18, 2021 03:28

tzarc requested changes Dec 21, 2021

View reviewed changes

Go all in on encoder hack

e4977eb

drashna requested review from tzarc and a team December 24, 2021 22:06

Lenbok reviewed Jan 12, 2022

View reviewed changes

keyboards/ploopyco/trackball_thumb/trackball_thumb.c Show resolved Hide resolved

Apply suggestions from code review

fadb123

Co-authored-by: Nick Brassel <nick@tzarc.org>

fhanrath reviewed Jan 19, 2022

View reviewed changes

stale bot added the awaiting changes label Apr 16, 2022

stale bot removed the awaiting changes label Jun 4, 2022

drashna requested changes Jun 4, 2022

View reviewed changes

keyboards/ploopyco/trackball_thumb/config.h Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/config.h Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/config.h Show resolved Hide resolved

keyboards/ploopyco/trackball_thumb/trackball_thumb.c Show resolved Hide resolved

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 23, 2022

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 29, 2022

drashna mentioned this pull request Aug 30, 2022

[Keyboard] Ploopy Thumb Trackball #18214

Merged

8 tasks

drashna closed this Aug 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the Ploopy Thumb #14668

Adding the Ploopy Thumb #14668

ploopyco commented Oct 1, 2021

fauxpark left a comment

kevinlekiller commented Dec 10, 2021 •

edited

Loading

kevinlekiller commented Dec 10, 2021

drashna left a comment

ploopyco commented Dec 14, 2021

drashna commented Dec 14, 2021

Lenbok commented Dec 24, 2021

Lenbok commented Dec 24, 2021

drashna commented Dec 24, 2021

fauxpark commented Dec 25, 2021

fhanrath left a comment

fhanrath Jan 18, 2022

drashna Jan 22, 2022

fhanrath Jan 18, 2022

noclew Jun 7, 2022

fhanrath Aug 18, 2022 •

edited

Loading

stale bot commented Apr 16, 2022

github-actions bot commented Jul 23, 2022

drashna commented Jul 28, 2022

drashna commented Aug 30, 2022

Adding the Ploopy Thumb #14668

Adding the Ploopy Thumb #14668

Conversation

ploopyco commented Oct 1, 2021

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark left a comment

Choose a reason for hiding this comment

kevinlekiller commented Dec 10, 2021 • edited Loading

kevinlekiller commented Dec 10, 2021

drashna left a comment

Choose a reason for hiding this comment

ploopyco commented Dec 14, 2021

drashna commented Dec 14, 2021

Lenbok commented Dec 24, 2021

Lenbok commented Dec 24, 2021

drashna commented Dec 24, 2021

fauxpark commented Dec 25, 2021

fhanrath left a comment

Choose a reason for hiding this comment

fhanrath Jan 18, 2022

Choose a reason for hiding this comment

drashna Jan 22, 2022

Choose a reason for hiding this comment

fhanrath Jan 18, 2022

Choose a reason for hiding this comment

noclew Jun 7, 2022

Choose a reason for hiding this comment

fhanrath Aug 18, 2022 • edited Loading

Choose a reason for hiding this comment

stale bot commented Apr 16, 2022

github-actions bot commented Jul 23, 2022

drashna commented Jul 28, 2022

drashna commented Aug 30, 2022

kevinlekiller commented Dec 10, 2021 •

edited

Loading

fhanrath Aug 18, 2022 •

edited

Loading