Adding Dygma Raise #13543

ibash · 2021-07-14T07:36:45Z

This adds support for the Dygma Raise. Since QMK doesn't yet support the SAMD21 MCU (which the neuron uses), instead this uses a STM32 Blackpill that connects to each half.

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This adds support for the Dygma Raise. Since QMK doesn't yet support the SAMD21 MCU, instead this uses a STM32 Blackpill that connects to each half.

jjerrell

js is sort of foreign to me but all else looks good!

LAYOUT_all is just a copy of the iso layout, but as per docs, this is recommended.

ibash · 2021-07-17T03:43:15Z

@drashna could I get a review?

keyboards/dygma/raise/config.h

keyboards/dygma/raise/create-led-config.js

keyboards/dygma/raise/keymaps/ansi/keymap.c

keyboards/dygma/raise/matrix.c

keyboards/dygma/raise/readme.md

keyboards/dygma/raise/raise.c

keyboards/dygma/raise/matrix.c

Co-authored-by: Joel Challis <git@zvecr.com>

1. Move keyboard to handwired 2. Consolidate led config away from keymaps 3. Add copyright headers

ibash · 2021-07-19T09:43:49Z

Thanks @zvecr -- back to you!

This fixes a bug with leds not turning off completely

keyboards/handwired/dygma/raise/matrix.c

elfmimi · 2021-08-07T03:52:46Z

What will happen when proper SAMD21 arrives? I mean, will this STM32 approach go away and give its way to SAMD21 one?

oh, I noticed. this one is placed under keyboards/handwired .
so more proper one should come in as keyboards/dygma/raise . then it's all alright.

ibash · 2021-08-15T00:38:18Z

@drashna || @zvecr can this be merged?

keyboards/handwired/dygma/raise/keymaps/ansi/readme.md

keyboards/handwired/dygma/raise/keymaps/ansi/keymap.c

keyboards/handwired/dygma/raise/keymaps/default/keymap.c

keyboards/handwired/dygma/raise/keymaps/default/readme.md

keyboards/handwired/dygma/raise/keymaps/iso/keymap.c

keyboards/handwired/dygma/raise/keymaps/iso/readme.md

keyboards/handwired/dygma/raise/raise.c

keyboards/handwired/dygma/raise/readme.md

keyboards/handwired/dygma/raise/rules.mk

keyboards/handwired/dygma/raise/create-led-config.js

Co-authored-by: Ryan <fauxpark@gmail.com>

As per qmk#13543 (comment)

ibash · 2021-08-22T21:45:02Z

@fauxpark we previously discussed converting to matrix lite, most of the matrix lite functionality would have to be bypassed, which doesn't make much sense: https://github.com/qmk/qmk_firmware/pull/13543/files#r680152929

Is that a blocker?

The qmk build files still confuse me, can you be more specific on what should go in what file? Is this right?

handwired/dygma/raise/ansi/info.json
- Copy of info.json but only with LAYOUT_ansi and not with LAYOUT_iso
- Should this have LAYOUT_all or not?
handwired/dygma/raise/ansi/ansi.h
- #define LAYOUT_ansi(
- Should this have LAYOUT_all or not?
handwired/dygma/raise/iso/info.json
- Copy of info.json but only with LAYOUT_iso and not with LAYOUT_ansi
- Should this have LAYOUT_all or not?
handwired/dygma/raise/iso/iso.h
- #define LAYOUT_iso(
- Should this have LAYOUT_all or not?
Should keymaps also be moved to subfolders?
Should I delete LAYOUT_all then?

Any other changes required to get this merged?

fauxpark · 2021-08-24T08:35:10Z

1 to 4 are correct, and each should have LAYOUT_all.
5. Given that there seems to be a hardware difference between the ANSI and ISO "revisions", I'd say yes, they each need their own keymaps folder.
6. Nope.

ibash · 2021-09-13T17:27:44Z

I have the changes on a branch, just need to test it. Coming soon!

keyboards/handwired/dygma/raise/rules.mk

keyboards/handwired/dygma/raise/raise.h

keyboards/handwired/dygma/raise/iso/info.json

keyboards/handwired/dygma/raise/ansi/info.json

keyboards/handwired/dygma/raise/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

ibash · 2021-09-21T16:59:01Z

Thanks for the quick review @fauxpark! Applied and I tested it on hardware.

ibash · 2021-09-29T18:09:02Z

@fauxpark any chance this can be merged?

stale · 2022-01-03T20:44:43Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

ibash · 2022-01-04T17:36:45Z

Bump

keyboards/handwired/dygma/raise/rules.mk

drashna · 2022-01-04T20:53:34Z

keyboards/handwired/dygma/raise/rules.mk

+# Build Options
+#   change yes to no to disable
+#
+BOOTMAGIC_ENABLE = no       # Enable Bootmagic Lite


We do highly recommend enabling this, since it adds a way to get into the bootloader to reflash, if a reset button isn't readily accessible.

keyboards/handwired/dygma/raise/readme.md

Co-authored-by: Drashna Jaelre <drashna@live.com>

ridingqwerty

Looks good to me.

drashna · 2022-01-09T19:56:59Z

Thanks!

Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com>

Adding Dygma Raise

c8d5f16

This adds support for the Dygma Raise. Since QMK doesn't yet support the SAMD21 MCU, instead this uses a STM32 Blackpill that connects to each half.

github-actions bot added keyboard keymap labels Jul 14, 2021

jjerrell approved these changes Jul 15, 2021

View reviewed changes

Adding LAYOUT_all and default keymaps for dygma raise

ffa7aeb

LAYOUT_all is just a copy of the iso layout, but as per docs, this is recommended.

Detect when a raise side is connected

cfaf0dd

zvecr requested changes Jul 17, 2021

View reviewed changes

zvecr requested a review from a team July 17, 2021 23:46

ibash and others added 3 commits July 19, 2021 02:07

Apply suggestions from code review

5da4adf

Co-authored-by: Joel Challis <git@zvecr.com>

Cleanup as per code review

4270cd5

1. Move keyboard to handwired 2. Consolidate led config away from keymaps 3. Add copyright headers

Enable mouse keys

693117b

ibash requested review from zvecr and removed request for a team July 19, 2021 09:43

Alternate between hands when transmitting led banks

21c2558

This fixes a bug with leds not turning off completely

drashna reviewed Jul 29, 2021

View reviewed changes

keyboards/handwired/dygma/raise/matrix.c Show resolved Hide resolved

drashna approved these changes Aug 7, 2021

View reviewed changes

drashna requested a review from a team August 8, 2021 04:56

ibash requested review from drashna and removed request for a team August 15, 2021 00:38

drashna approved these changes Aug 15, 2021

View reviewed changes

drashna requested a review from a team August 16, 2021 13:34

fauxpark requested changes Aug 16, 2021

View reviewed changes

ibash and others added 2 commits August 16, 2021 10:36

Apply suggestions from code review

1d3b636

Co-authored-by: Ryan <fauxpark@gmail.com>

Remove create-led-config.js

f86ef8a

ibash requested a review from fauxpark August 16, 2021 23:47

Separate ansi and iso keyboards into revisions

48f0bf9

As per qmk#13543 (comment)

Use matrix lite for dygma raise

b2f388f

fauxpark requested changes Sep 21, 2021

View reviewed changes

Apply suggestions from code review

e2adcef

Co-authored-by: Ryan <fauxpark@gmail.com>

ibash requested review from fauxpark and drashna September 21, 2021 16:59

drashna approved these changes Oct 11, 2021

View reviewed changes

stale bot added the awaiting changes label Jan 3, 2022

ibash requested a review from drashna January 4, 2022 18:01

stale bot removed the awaiting changes label Jan 4, 2022

drashna requested changes Jan 4, 2022

View reviewed changes

ibash and others added 2 commits January 4, 2022 13:55

Update keyboards/handwired/dygma/raise/readme.md

a046568

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/handwired/dygma/raise/rules.mk

aca0754

Co-authored-by: Drashna Jaelre <drashna@live.com>

ibash requested a review from drashna January 4, 2022 21:55

drashna approved these changes Jan 5, 2022

View reviewed changes

drashna requested a review from a team January 5, 2022 00:06

ibash removed the request for review from a team January 5, 2022 00:22

ridingqwerty approved these changes Jan 5, 2022

View reviewed changes

drashna merged commit ec78aca into qmk:master Jan 9, 2022

ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022

[Keyboard] Adding Dygma Raise (qmk#13543)

5c28954

Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Dygma Raise #13543

Adding Dygma Raise #13543

ibash commented Jul 14, 2021 •

edited

Loading

jjerrell left a comment

ibash commented Jul 17, 2021

ibash commented Jul 19, 2021

elfmimi commented Aug 7, 2021 •

edited

Loading

ibash commented Aug 15, 2021

ibash commented Aug 22, 2021

fauxpark commented Aug 24, 2021

ibash commented Sep 13, 2021

ibash commented Sep 21, 2021

ibash commented Sep 29, 2021

stale bot commented Jan 3, 2022

ibash commented Jan 4, 2022

drashna Jan 4, 2022

ridingqwerty left a comment

drashna commented Jan 9, 2022

Adding Dygma Raise #13543

Adding Dygma Raise #13543

Conversation

ibash commented Jul 14, 2021 • edited Loading

Types of Changes

Checklist

jjerrell left a comment

Choose a reason for hiding this comment

ibash commented Jul 17, 2021

ibash commented Jul 19, 2021

elfmimi commented Aug 7, 2021 • edited Loading

ibash commented Aug 15, 2021

ibash commented Aug 22, 2021

fauxpark commented Aug 24, 2021

ibash commented Sep 13, 2021

ibash commented Sep 21, 2021

ibash commented Sep 29, 2021

stale bot commented Jan 3, 2022

ibash commented Jan 4, 2022

drashna Jan 4, 2022

Choose a reason for hiding this comment

ridingqwerty left a comment

Choose a reason for hiding this comment

drashna commented Jan 9, 2022

ibash commented Jul 14, 2021 •

edited

Loading

elfmimi commented Aug 7, 2021 •

edited

Loading