-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set some default configurations for GMMK Pro #13219
Conversation
@drashna I ended up opening this PR against |
This should be okay. It will get merged into develop, if/when it's merged into master. And given the type of change, it shouldn't cause any issues. |
Can confirm this seems to work fine on my board EDIT: Interestingly this seems to cause problems with my KVM:
In any case, this is a fairly niche usecase, and I suspect it has something to do with my laptop just being too slow to do some handshake or something, in general this is probably good for most users. |
@Gigahawk I don't think that's such a niche scenario. I myself switch between machines sometimes, though I have a simple USB switch instead of a full KVM. Could you maybe comment out some of the options and see if that helps? |
Looks like removing |
It's probably more connected to quirks of the USB controller and whatnot, I imagine. Let's remove it then. |
* Set some default configurations for GMMK Pro * Remove FORCE_NKRO to avoid issues with KVMs
@Gigahawk sorry for the necro, but I found out that MOUSEKEY causes a lot of issues on this board with KVM switches. It seems to cause it on many others too, see #15949. Maybe it's worth trying to see if you can now keep NKRO enabled and also be able to use your KVM. |
Description
Adding a few configurations as defaults for the GMMK Pro which I think make sense either because they're either
Maybe it would be up to @glorious-qmk to check if these changes make sense for the GMMK Pro, but I think at least setting
USB_POLLING_INTERVAL_MS
to 1 does.Types of Changes
Issues Fixed or Closed by This PR
Checklist