Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure 'cformat' only runs on core files #12909

Merged
merged 3 commits into from
May 18, 2021
Merged

Make sure 'cformat' only runs on core files #12909

merged 3 commits into from
May 18, 2021

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented May 15, 2021 •
edited
Loading

Description

The 'cformat' subcommand should only run on "core" files when executed by the CI.
CI now should use the new --core-only argument.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia
Make sure 'cformat' only runs on core files
34b3721 
The 'cformat' subcommand should only run on "core" files by default,
unless the '-f' argument is passed to force running on other files.
@github-actions github-actions bot added cli qmk cli command python labels May 15, 2021
@Erovia Erovia added the CI label May 15, 2021
@Erovia Erovia requested a review from a team May 15, 2021 08:32
@Erovia Erovia marked this pull request as draft May 18, 2021 18:46
@Erovia Erovia marked this pull request as ready for review May 18, 2021 19:03
@Erovia @skullydazed
Update lib/python/qmk/cli/cformat.py
36790c7 
Co-authored-by: Zach White <skullydazed@drpepper.org>
@Erovia Erovia merged commit 3023015 into qmk:master May 18, 2021
@Erovia Erovia deleted the cli/cformat_fix branch May 18, 2021 19:26
leland-kwong pushed a commit to leland-kwong/qmk_firmware that referenced this pull request May 23, 2021
@Erovia @skullydazed @leland-kwong
Make sure 'cformat' only runs on core files (qmk#12909)
8e9ab22 
Co-authored-by: Zach White <skullydazed@drpepper.org>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@Erovia @skullydazed @HokieGeek
Make sure 'cformat' only runs on core files (qmk#12909)
195bbf3 
Co-authored-by: Zach White <skullydazed@drpepper.org>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Erovia @skullydazed @nhongooi
Make sure 'cformat' only runs on core files (qmk#12909)
e0362da 
Co-authored-by: Zach White <skullydazed@drpepper.org>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Erovia @skullydazed
Make sure 'cformat' only runs on core files (qmk#12909)
2e85e09 
Co-authored-by: Zach White <skullydazed@drpepper.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
CI cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erovia @skullydazed @zvecr