Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giant macro pad #12905

Merged
merged 5 commits into from
May 16, 2021
Merged

Giant macro pad #12905

merged 5 commits into from
May 16, 2021

Conversation

mini-ninja-64
Copy link
Contributor

Description

This PR will add a 20x20 macropad with a default & via keymap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 14, 2021
tzarc
tzarc requested changes May 16, 2021
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some queries.

keyboards/cutie_club/giant_macro_pad/chconf.h Outdated Show resolved Hide resolved
keyboards/cutie_club/giant_macro_pad/mcuconf.h Outdated Show resolved Hide resolved
keyboards/cutie_club/giant_macro_pad/readme.md Show resolved Hide resolved
@tzarc tzarc requested a review from a team May 16, 2021 21:20
drashna
drashna approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drashna drashna merged commit 3e1fa8c into qmk:master May 16, 2021
@mini-ninja-64 mini-ninja-64 mentioned this pull request May 17, 2021
Merged
6 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@mini-ninja-64 @HokieGeek
[Keyboard] Giant macro pad (qmk#12905)
c5375b5
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mini-ninja-64 @nhongooi
[Keyboard] Giant macro pad (qmk#12905)
4078da0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mini-ninja-64 @drashna @tzarc @fauxpark