Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redox custom keymap (jeherve): updates to deprecated code and bugfixes #12738

Merged
merged 10 commits into from
May 13, 2021
Merged

Redox custom keymap (jeherve): updates to deprecated code and bugfixes #12738

merged 10 commits into from
May 13, 2021

Conversation

jeherve
Copy link
Contributor

@jeherve jeherve commented Apr 29, 2021 •
edited
Loading

Description

This PR makes some changes to a personal keymap for the Redox keyboard. It doesn't bring any new features, but fixes a small bug and removes code that is now deprecated.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation. I've updated the readme for my keymap.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 30, 2021 11:46
jeherve added 9 commits May 4, 2021 09:51
@jeherve
Replace UC_OSX (deprecated) by UC_MAC
6ae82c4 
See https://beta.docs.qmk.fm/using-qmk/software-features/feature_unicode
@jeherve
Set unicode for mac input mode in config
94fce9f 
See https://beta.docs.qmk.fm/using-qmk/software-features/feature_unicode#3-setting-the-input-mode-id-setting-the-input-mode

> Using UNICODE_SELECTED_MODES is preferable to calling set_unicode_input_mode() in matrix_init_user() or similar functions, since it's better integrated into the Unicode system and has the added benefit of avoiding unnecessary writes to EEPROM.
@jeherve
Fix indentation
679904f
@jeherve
Switch to using unicode for non breaking space
bf97872
@jeherve
Fix audio mode
1350158 
I had started setting this up before but never completed it.
@jeherve
Replace use of deprecated send_unicode_hex_string()
8cce9d4
@jeherve
Update readme and changelog
ae632ab
@jeherve
Add GPL header comment
affda44
@jeherve
Switch to register_unicode for emoji macros
f494b99 
See qmk#12738 (comment)
@jeherve jeherve force-pushed the update/deprecations-jeherve branch from d9b7d3b to f494b99 Compare May 4, 2021 07:51
@fauxpark fauxpark requested a review from a team May 4, 2021 07:57
drashna
drashna requested changes May 13, 2021
View reviewed changes
keyboards/redox/keymaps/jeherve/keymap.c Outdated Show resolved Hide resolved
keyboards/redox/keymaps/jeherve/keymap.c Outdated Show resolved Hide resolved
keyboards/redox/keymaps/jeherve/keymap.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from drashna May 13, 2021 09:04
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 6e5e346 into qmk:master May 13, 2021
@jeherve
Copy link
Contributor Author

jeherve commented May 13, 2021

Thank you both!

jeherve added a commit to jeherve/redox-layout that referenced this pull request May 13, 2021
@jeherve
Janitorial: remove deprecated and soon-to-be deprecated options
3b017c8 
For more details, see original PR:
qmk/qmk_firmware#12738
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@jeherve @drashna @toddyamakawa
Redox custom keymap (jeherve): updates to deprecated code and bugfixes (
4d69b4b 
qmk#12738)

Co-authored-by: Drashna Jael're <drashna@live.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@jeherve @drashna @HokieGeek
Redox custom keymap (jeherve): updates to deprecated code and bugfixes (
ad85f77 
qmk#12738)

Co-authored-by: Drashna Jael're <drashna@live.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@jeherve @drashna @nhongooi
Redox custom keymap (jeherve): updates to deprecated code and bugfixes (
52b3a3c 
qmk#12738)

Co-authored-by: Drashna Jael're <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @fauxpark @drashna