Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DracuLad: add Configurator data and rework layout macro #12727

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

noroadsleft
Copy link
Member

Description

Adds an info.json file for QMK Configurator, reworks the layout macro so the keymaps resemble the assembled hardware, and a touch-up of the readme (spelling, capitalization, and white space).

cc @MangoIV (keyboard maintainer) - none of these changes affects behaviour, but the changes will make it easier for users of this board.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@MangoIV
Copy link

MangoIV commented Apr 28, 2021

Well. Thank you for your work. What did you change about the OLED picture?

Arranges the layout macro and keycodes to resemble the physical layout.
Corrections to capitalization and spelling, and removal of extra white space.
@noroadsleft
Copy link
Member Author

Well. Thank you for your work. What did you change about the OLED picture?

Whoops, that was a mistake. Part of QMK's default configuration instructs text editors to remove trailing whitespace by default, which is what happened to the OLED code block.

I've reverted that change.

@noroadsleft noroadsleft merged commit 8190a79 into qmk:master Apr 29, 2021
@noroadsleft noroadsleft deleted the cf/draculad branch April 29, 2021 18:25
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
* add info.json file

* refactor keymaps for readability

* rework layout macro

Arranges the layout macro and keycodes to resemble the physical layout.

* readme touch-up

Corrections to capitalization and spelling, and removal of extra white space.
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
* add info.json file

* refactor keymaps for readability

* rework layout macro

Arranges the layout macro and keycodes to resemble the physical layout.

* readme touch-up

Corrections to capitalization and spelling, and removal of extra white space.
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
* add info.json file

* refactor keymaps for readability

* rework layout macro

Arranges the layout macro and keycodes to resemble the physical layout.

* readme touch-up

Corrections to capitalization and spelling, and removal of extra white space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants