-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DracuLad: add Configurator data and rework layout macro #12727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well. Thank you for your work. What did you change about the OLED picture? |
Arranges the layout macro and keycodes to resemble the physical layout.
Corrections to capitalization and spelling, and removal of extra white space.
noroadsleft
force-pushed
the
cf/draculad
branch
from
April 28, 2021 19:30
bb547d8
to
b302044
Compare
Whoops, that was a mistake. Part of QMK's default configuration instructs text editors to remove trailing whitespace by default, which is what happened to the OLED code block. I've reverted that change. |
fauxpark
approved these changes
Apr 29, 2021
rizo
pushed a commit
to rizo/qmk_firmware
that referenced
this pull request
May 10, 2021
* add info.json file * refactor keymaps for readability * rework layout macro Arranges the layout macro and keycodes to resemble the physical layout. * readme touch-up Corrections to capitalization and spelling, and removal of extra white space.
toddyamakawa
pushed a commit
to toddyamakawa/qmk_firmware
that referenced
this pull request
May 19, 2021
* add info.json file * refactor keymaps for readability * rework layout macro Arranges the layout macro and keycodes to resemble the physical layout. * readme touch-up Corrections to capitalization and spelling, and removal of extra white space.
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
* add info.json file * refactor keymaps for readability * rework layout macro Arranges the layout macro and keycodes to resemble the physical layout. * readme touch-up Corrections to capitalization and spelling, and removal of extra white space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
info.json
file for QMK Configurator, reworks the layout macro so the keymaps resemble the assembled hardware, and a touch-up of the readme (spelling, capitalization, and white space).cc @MangoIV (keyboard maintainer) - none of these changes affects behaviour, but the changes will make it easier for users of this board.
Types of Changes
Checklist