Minifan minor issues #12592
Merged
Minifan minor issues #12592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problems where: ① When pressing Shift on _NSY when going to _DRA, the shift did not register, because that Shift was a QMK hold/tap macro, which does not register the Shift as it is done in this keymap. ② This also solves the long existing ~ imperfection, so that it now can be pressed without Shift. The documentation has not yet been updated.
“Does ~, `, as …”. A fair amount of graphics files needed to be updated, by removing ‛`’ from the _NSY layer shift key.
Leds always off on ‛Alternative Base’ user configuration option.
Messed a little with some babble in readme about keyboard efficiency. Space is the most used key, it is difficult to change if you are used to typing it with the other thumb. Hence added an option to switch the meaning of the “space bars” keys (center on thumbs row).
This somewhat loose Page-Up on _MOV was previously sacrificed, to make room for TRNS, but that is unnecessary.
This arrow was missing.
… in graphics chapter 4.1.
Qwerty Base-Arrow compilation changes the regular Qwerty layout, which could be confusing. Made it clearer why this is happening.
The manual already said it, and the documentation here is probably already about 10 times too much.
Keycaps view, saturation was off a little ;-)
14 tasks
fauxpark
approved these changes
Apr 18, 2021
• Inserted register_unicode() • Corrected comment symbol mistake in config.h (thx fauxpark)
Removing send_unicode_hex_string().
drashna
approved these changes
Apr 20, 2021
|
Thanks! |
|
Thank you all 😊 |
makenova
pushed a commit
to makenova/qmk_firmware
that referenced
this pull request
Apr 26, 2021
rizo
pushed a commit
to rizo/qmk_firmware
that referenced
this pull request
May 10, 2021
toddyamakawa
pushed a commit
to toddyamakawa/qmk_firmware
that referenced
this pull request
May 19, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved the “-~” issue, by making them custom macros (_NSY layer).
This also solved a mistake which was recently discovered: the Shifts on _NSY layer where not recognized, when passing through _NSY to another layer _BON or _DRA, because they where native QMK keycodes which didn't hook into the Shift system here. This meant that the order in which modifiers and layer switches where pressed ended up mattering, which it should not. Shift now works seemlessly regardless of key pressing order, and “~” does not require Shift on _NSY, as originally intended. (fixed)
Added a user option to switch left/right “Spacebar” action on Base layers.
Added some layer activation arrows in that particular graphic.
Leds can now also be configured to stay off completely for the “Alternative Base” layer, due to new space savings (16 bit layer).
Bunch of readme reworking.
Types of Changes
Issues Fixed or Closed by This PR
The “`~” issue, where “~” should have been activated without Shift, but native QMK didn't seem to allow it.
Shift on _NSY was not hooked into the local Shift detection system, causing a somewhat rare modifier/layer key order issue.
Checklist