Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checking board master function #12493

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Update checking board master function #12493

merged 1 commit into from
Apr 25, 2021

Conversation

calebchongc
Copy link

@calebchongc calebchongc commented Apr 6, 2021 •
edited
Loading

changed is_master to is_keyboard_master()

Tried to compile+flash and didn't work, referenced default template to fix this on my board

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@calebchongc
Update checking board master function
05aeab2 
changed is_master to is_keyboard_master()
@github-actions github-actions bot added the keymap label Apr 6, 2021
@fauxpark
Copy link
Member

fauxpark commented Apr 9, 2021

@ninjonas

@drashna drashna requested a review from a team April 19, 2021 08:28
@tzarc tzarc merged commit 5b394e8 into qmk:master Apr 25, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@calebchongc @makenova
Update checking board master function (qmk#12493)
a822a39 
changed is_master to is_keyboard_master()
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@calebchongc @rizo
Update checking board master function (qmk#12493)
a0a0db4 
changed is_master to is_keyboard_master()
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@calebchongc @toddyamakawa
Update checking board master function (qmk#12493)
fff0a57 
changed is_master to is_keyboard_master()
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@calebchongc @HokieGeek
Update checking board master function (qmk#12493)
55858d6 
changed is_master to is_keyboard_master()
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@calebchongc
Update checking board master function (qmk#12493)
6d5b195 
changed is_master to is_keyboard_master()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calebchongc @fauxpark @drashna @tzarc