Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add adelais rev4 #12443

Merged
merged 4 commits into from
Apr 20, 2021
Merged

add adelais rev4 #12443

merged 4 commits into from
Apr 20, 2021

Conversation

mechlovin
Copy link
Contributor

Description

Add Adelais rev.4.
Thanks.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechlovin
Copy link
Contributor Author

bump

@drashna
Copy link
Member

drashna commented Apr 19, 2021

Also:

☒ Missing keyboards/mechlovin/adelais/standard_led/readme.md
☒ Lint check failed!
linting mechlovin/adelais/standard_led/rev4
☒ Missing keyboards/mechlovin/adelais/standard_led/rev4/readme.md
☒ Lint check failed!

@drashna drashna requested a review from a team April 20, 2021 04:04
@drashna
Copy link
Member

drashna commented Apr 20, 2021

Thanks!

@drashna drashna merged commit 0d5458a into qmk:master Apr 20, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@mechlovin @makenova
[Keyboard] add adelais rev4 (qmk#12443)
5de237b
@mechlovin mechlovin mentioned this pull request May 6, 2021
Merged
6 tasks
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@mechlovin @rizo
[Keyboard] add adelais rev4 (qmk#12443)
1a29558
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@mechlovin @toddyamakawa
[Keyboard] add adelais rev4 (qmk#12443)
41df33f
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@mechlovin @HokieGeek
[Keyboard] add adelais rev4 (qmk#12443)
b6bdc7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mechlovin @drashna @fauxpark