Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kc keymap/layout from khord chocopad keymap per #12160 #12409

Merged
merged 4 commits into from
Apr 3, 2021
Merged

Remove kc keymap/layout from khord chocopad keymap per #12160 #12409

merged 4 commits into from
Apr 3, 2021

Conversation

khord
Copy link
Contributor

@khord khord commented Mar 28, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#12160

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei requested a review from a team March 30, 2021 09:10
fauxpark
fauxpark requested changes Mar 30, 2021
View reviewed changes
keyboards/keebio/chocopad/keymaps/khord/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/chocopad/keymaps/khord/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/chocopad/keymaps/khord/keymap.c Outdated Show resolved Hide resolved
khord and others added 3 commits March 30, 2021 15:03
@khord @fauxpark
Update keyboards/keebio/chocopad/keymaps/khord/keymap.c
97b48dd 
Co-authored-by: Ryan <fauxpark@gmail.com>
@khord @fauxpark
Update keyboards/keebio/chocopad/keymaps/khord/keymap.c
3555aea 
Co-authored-by: Ryan <fauxpark@gmail.com>
@khord @fauxpark
Update keyboards/keebio/chocopad/keymaps/khord/keymap.c
31f95df 
Co-authored-by: Ryan <fauxpark@gmail.com>
@khord khord requested a review from fauxpark March 30, 2021 19:04
@drashna
Copy link
Member

drashna commented Apr 3, 2021

Thanks!

@drashna drashna merged commit 8d3581a into qmk:master Apr 3, 2021
@khord khord deleted the khord-update branch April 3, 2021 04:50
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@khord @fauxpark @makenova
[Keymap] Remove kc keymap from khord chocopad keymap (qmk#12409)
fcd3788 
Co-authored-by: Ryan <fauxpark@gmail.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@khord @fauxpark @HokieGeek
[Keymap] Remove kc keymap from khord chocopad keymap (qmk#12409)
27eff0d 
Co-authored-by: Ryan <fauxpark@gmail.com>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@khord @fauxpark @mrtnee
[Keymap] Remove kc keymap from khord chocopad keymap (qmk#12409)
ee19b9d 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khord @drashna @mtei @fauxpark