Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the GK64 layout to DZ60 #12378

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Added the GK64 layout to DZ60 #12378

merged 2 commits into from
Mar 29, 2021

Conversation

str-dst
Copy link
Contributor

@str-dst str-dst commented Mar 25, 2021 •
edited
Loading

Description

The DZ60 PCB was missing the GK64 layout. Since it's one of the more commonly used layouts for the board I thought it would make sense to add it.
I used LAYOUT_gk64 as a preset name but I'm open for other suggestions there.

It has the 2u left shift and all 1u keys on the right side.
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 25, 2021 11:32
noroadsleft
noroadsleft requested changes Mar 27, 2021
View reviewed changes
keyboards/dz60/dz60.h Outdated Show resolved Hide resolved
keyboards/dz60/dz60.h Outdated Show resolved Hide resolved
keyboards/dz60/info.json Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/gk64/keymap.c Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/gk64/keymap.c Outdated Show resolved Hide resolved
@str-dst @noroadsleft
Apply suggestions from code review
08da88d 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit ae59a51 into qmk:master Mar 29, 2021
@noroadsleft
Copy link
Member

Thanks!

makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@str-dst @makenova
Added the 64_ansi (GK64) layout to DZ60 (qmk#12378)
12e3cad 
* add gk64 layout

* Apply suggestions from code review
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@str-dst @HokieGeek
Added the 64_ansi (GK64) layout to DZ60 (qmk#12378)
3ca0449 
* add gk64 layout

* Apply suggestions from code review
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@str-dst @mrtnee
Added the 64_ansi (GK64) layout to DZ60 (qmk#12378)
3b287ee 
* add gk64 layout

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@str-dst @noroadsleft @tzarc @fauxpark