Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use layout aliases when processing info.json #12333

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Use layout aliases when processing info.json #12333

merged 1 commit into from
Mar 23, 2021

Conversation

skullydazed
Copy link
Member

Description

Some info.json files use alias names instead of the real layout name. This change correctly integrates the layout data when this happens.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team March 22, 2021 18:13
@github-actions github-actions bot added cli qmk cli command python labels Mar 22, 2021
noroadsleft
noroadsleft approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skullydazed skullydazed merged commit e1a7027 into master Mar 23, 2021
@skullydazed skullydazed deleted the improve_layout_aliases branch March 23, 2021 01:58
jennyzeng pushed a commit to jennyzeng/qmk_firmware that referenced this pull request Mar 25, 2021
@skullydazed @jennyzeng
use layout aliases when processing info.json (qmk#12333)
0fca2b0
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Mar 28, 2021
@skullydazed @violet-fish
use layout aliases when processing info.json (qmk#12333)
5835a72
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@skullydazed @mrtnee
use layout aliases when processing info.json (qmk#12333)
6d8cfee
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
use layout aliases when processing info.json (qmk#12333)
0f76968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @fauxpark @noroadsleft