Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Perixx Periboard-512 Converter #12324

Merged
merged 17 commits into from
May 16, 2021
Merged

Added Perixx Periboard-512 Converter #12324

merged 17 commits into from
May 16, 2021

Conversation

Sife-ops
Copy link

@Sife-ops Sife-ops commented Mar 21, 2021 •
edited
Loading

Description

Converter for the Perixx Periboard-512.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Sife-ops Sife-ops changed the title Perixx Periboard-512 Converter Added Perixx Periboard-512 Converter Mar 26, 2021
@Sife-ops Sife-ops requested a review from drashna April 14, 2021 07:37
Sife-ops
Sife-ops commented Apr 14, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sife-ops @drashna
Update keyboards/converter/periboard_512/config.h
75051c1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sife-ops
Sife-ops commented Apr 27, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

keyboards/converter/periboard_512/config.h Outdated
#define MATRIX_COLS 19
#define MATRIX_ROWS 8
#define DEBOUNCE 5
#define DIODE_DIRECTION ROW2COL
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

@Sife-ops Sife-ops requested a review from drashna April 27, 2021 11:21
Sife-ops
Sife-ops commented Apr 27, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see one area that needs changing.

fauxpark
fauxpark requested changes Apr 27, 2021
View reviewed changes
keyboards/converter/periboard_512/rules.mk Outdated Show resolved Hide resolved
keyboards/converter/periboard_512/config.h Outdated Show resolved Hide resolved
keyboards/converter/periboard_512/rules.mk Outdated Show resolved Hide resolved
keyboards/converter/periboard_512/readme.md Outdated
@@ -0,0 +1,47 @@
# Periboard-512 QMK Conversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should follow the template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look at this soon.

Sife-ops and others added 3 commits April 28, 2021 10:51
@Sife-ops @fauxpark
Update keyboards/converter/periboard_512/rules.mk
f8a152e 
Co-authored-by: Ryan <fauxpark@gmail.com>
@Sife-ops @fauxpark
Update keyboards/converter/periboard_512/config.h
fd57239 
Co-authored-by: Ryan <fauxpark@gmail.com>
@Sife-ops @fauxpark
Update keyboards/converter/periboard_512/rules.mk
3fcefa9 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sife-ops
Sife-ops commented Apr 28, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look.

Sife-ops
Sife-ops commented May 2, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new readme.md following the guidelines, making a separate gist for the build instructions.

@Sife-ops Sife-ops requested a review from fauxpark May 2, 2021 04:04
fauxpark
fauxpark reviewed May 14, 2021
View reviewed changes
keyboards/converter/periboard_512/keymaps/default/keymap.c Outdated
SNEK
};

const uint32_t PROGMEM unicode_map[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add a keymap-level rules.mk with UNICODEMAP_ENABLE = yes for this to work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out. I never finished filling these, so removing.

Sife-ops and others added 2 commits May 15, 2021 18:21
Sife-ops
Sife-ops commented May 15, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dead layout code.

@Sife-ops Sife-ops requested a review from fauxpark May 15, 2021 18:47
Sife-ops
Sife-ops commented May 15, 2021
View reviewed changes
Copy link
Author

@Sife-ops Sife-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted empty config.h.

@Sife-ops Sife-ops requested a review from fauxpark May 15, 2021 22:22
@fauxpark fauxpark requested a review from a team May 15, 2021 22:28
@drashna
Copy link
Member

drashna commented May 16, 2021

Thanks!

1 similar comment
@drashna
Copy link
Member

drashna commented May 16, 2021

Thanks!

@drashna drashna merged commit a5d7e83 into qmk:master May 16, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@Sife-ops @drashna
@fauxpark @HokieGeek
[Keyboard] Added Perixx Periboard-512 Converter (qmk#12324)
bfc0067 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Sife-ops @drashna
@fauxpark @nhongooi
[Keyboard] Added Perixx Periboard-512 Converter (qmk#12324)
5357e18 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sife-ops @drashna @fauxpark