Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix USER_PRINT on avr/atsam #12269

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Fix USER_PRINT on avr/atsam #12269

merged 2 commits into from
Mar 25, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 17, 2021

Description

Looks like i broke the logic during the tidy up within #11863.

uprints need to resolve upfront, so that the later undefs do not become too aggressive in what they then touch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 17, 2021
@zvecr zvecr requested a review from a team March 17, 2021 14:51
@github-actions github-actions bot added the core label Mar 17, 2021
@zvecr zvecr force-pushed the feature/fix_user_print branch from 09ba2b9 to cd1cbbb Compare March 17, 2021 14:59
@zvecr @fauxpark
Update tmk_core/common/arm_atsam/_print.h
0147d19 
Co-authored-by: Ryan <fauxpark@gmail.com>
@tzarc tzarc merged commit 1bb6d8d into qmk:master Mar 25, 2021
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Mar 28, 2021
@zvecr @fauxpark @violet-fish
Fix USER_PRINT on avr/atsam (qmk#12269)
c1023e9 
* Fix USER_PRINT on avr/atsam

* Update tmk_core/common/arm_atsam/_print.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@zvecr @fauxpark @mrtnee
Fix USER_PRINT on avr/atsam (qmk#12269)
aec5bad 
* Fix USER_PRINT on avr/atsam

* Update tmk_core/common/arm_atsam/_print.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @fauxpark
Fix USER_PRINT on avr/atsam (qmk#12269)
77a4bfb 
* Fix USER_PRINT on avr/atsam

* Update tmk_core/common/arm_atsam/_print.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark