Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L433 EEPROM support #12068

Closed
wants to merge 3 commits into from
Closed

L433 EEPROM support #12068

wants to merge 3 commits into from

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Feb 28, 2021 •
edited
Loading

Description

Add L433 EEPROM support.
Dependent on #12063
Will un-draft after hardware verification

based on the L4xx manual
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds L433 EEPROM support

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the base branch from master to develop February 28, 2021 22:52
@tzarc tzarc self-requested a review February 28, 2021 23:00
@tzarc tzarc self-assigned this Feb 28, 2021
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label Mar 2, 2021
@Xelus22
Copy link
Contributor Author

Xelus22 commented Apr 9, 2021

This is being closed since the current EEPROM assumes the flash can be written in half-word (16bits). However the L4 series can only support 64bit writes.

@Xelus22 Xelus22 closed this Apr 9, 2021
@Xelus22 Xelus22 deleted the l433_eeprom branch June 2, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc Awaiting requested review from tzarc

Assignees

@tzarc tzarc

Labels
awaiting_pr Relies on another PR to be merged first core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @drashna @tzarc