ADNS-5050 / Ploopy Nano / Ploopy Mini Trackballs #11994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Feb 23, 2021
|
Lint seems unhappy with the fact that keyboards/ploopyco/trackball_nano has no buttons (i.e. "layouts" is undefined in info.json and LAYOUT function is empty). Code compiles and runs correctly, but I'm not sure how to fix the lint errors. Any ideas? |
|
Testing identified a spurious scrolling issue. Will re-open PR later. |
|
Should be fine. Lint may not be happy, but it compiles, so that's what matters. |
drashna
reviewed
Mar 9, 2021
drashna
reviewed
Mar 9, 2021
drashna
requested changes
Mar 9, 2021
drashna
reviewed
Mar 9, 2021
drashna
approved these changes
Mar 9, 2021
tzarc
approved these changes
Mar 25, 2021
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
Mar 28, 2021
* added adns5050 sensor code, as well as implementations for the Ploopy Mini and the Ploopy Nano * fixed spurious scrolling issue * recommended fixes for pr linting and cleanup
6 tasks
mrtnee
pushed a commit
to mrtnee/qmk_firmware
that referenced
this pull request
Nov 20, 2021
* added adns5050 sensor code, as well as implementations for the Ploopy Mini and the Ploopy Nano * fixed spurious scrolling issue * recommended fixes for pr linting and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a driver for the ADNS-5050 optical mouse sensor.
Added implementations for the Ploopy Nano and Ploopy Mini trackball.
Types of Changes
Issues Fixed or Closed by This PR
Checklist