Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Daji Seis Cinco #11955

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Add Daji Seis Cinco #11955

merged 4 commits into from
Feb 22, 2021

Conversation

toraifu
Copy link
Contributor

@toraifu toraifu commented Feb 19, 2021

Description

Adding support for the Daji Seis Cinco, a minimalist 65% layout keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 19, 2021
@toraifu toraifu mentioned this pull request Feb 19, 2021
Merged
6 tasks
drashna
drashna requested changes Feb 20, 2021
View reviewed changes
keyboards/daji/seis_cinco/config.h Show resolved Hide resolved
keyboards/daji/seis_cinco/config.h Outdated Show resolved Hide resolved
keyboards/daji/seis_cinco/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/daji/seis_cinco/keymaps/split_backspace/keymap.c Show resolved Hide resolved
keyboards/daji/seis_cinco/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/daji/seis_cinco/seis_cinco.h Show resolved Hide resolved
keyboards/daji/seis_cinco/seis_cinco.c Show resolved Hide resolved
@drashna drashna requested a review from a team February 21, 2021 06:21
fauxpark
fauxpark requested changes Feb 21, 2021
View reviewed changes
keyboards/daji/seis_cinco/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/daji/seis_cinco/keymaps/split_backspace/keymap.c Outdated Show resolved Hide resolved
keyboards/daji/seis_cinco/rules.mk Outdated Show resolved Hide resolved
@toraifu @fauxpark
Apply requested changes
55b8211 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 3699949 into qmk:master Feb 22, 2021
drashna pushed a commit to drashna/qmk_firmware that referenced this pull request Feb 23, 2021
@toraifu @fauxpark @drashna
[Keyboard] Add Daji Seis Cinco (qmk#11955)
e0a41b5 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toraifu @drashna @fauxpark