Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ConsoleKeyboard #11950

Merged
merged 10 commits into from
Feb 20, 2021
Merged

Added ConsoleKeyboard #11950

merged 10 commits into from
Feb 20, 2021

Conversation

gazeddy
Copy link

@gazeddy gazeddy commented Feb 18, 2021

Description

Added Console Keyboard (again)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 18, 2021
zvecr
zvecr requested changes Feb 18, 2021
View reviewed changes
keyboards/handwired/consolekeyboard/config.h Outdated Show resolved Hide resolved
keyboards/handwired/consolekeyboard/consolekeyboard.c Outdated Show resolved Hide resolved
keyboards/handwired/consolekeyboard/consolekeyboard.h Show resolved Hide resolved
keyboards/handwired/consolekeyboard/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team February 18, 2021 22:56
gazeddy and others added 4 commits February 18, 2021 23:05
@gazeddy @zvecr
Update keyboards/handwired/consolekeyboard/rules.mk
62aa5e8 
Co-authored-by: Joel Challis <git@zvecr.com>
@gazeddy @zvecr
Update keyboards/handwired/consolekeyboard/consolekeyboard.h
0e6d7ad 
Co-authored-by: Joel Challis <git@zvecr.com>
@gazeddy @zvecr
Update keyboards/handwired/consolekeyboard/consolekeyboard.c
ba6cac8 
Co-authored-by: Joel Challis <git@zvecr.com>
@gazeddy @zvecr
Update keyboards/handwired/consolekeyboard/config.h
5a92a64 
Co-authored-by: Joel Challis <git@zvecr.com>
gazeddy and others added 3 commits February 20, 2021 10:22
@gazeddy @fauxpark
Update keyboards/handwired/consolekeyboard/rules.mk
d64b9ac 
Co-authored-by: Ryan <fauxpark@gmail.com>
@gazeddy @fauxpark
Update keyboards/handwired/consolekeyboard/readme.md
a34559c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@gazeddy @fauxpark
Update keyboards/handwired/consolekeyboard/keymaps/via/rules.mk
0ea03d1 
Co-authored-by: Ryan <fauxpark@gmail.com>
@zvecr zvecr requested a review from fauxpark February 20, 2021 20:50
fauxpark
fauxpark requested changes Feb 20, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing, I think.

keyboards/handwired/consolekeyboard/readme.md Outdated Show resolved Hide resolved
@gazeddy @fauxpark
Update keyboards/handwired/consolekeyboard/readme.md
4bada81 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit d35d65f into qmk:master Feb 20, 2021
@gazeddy gazeddy deleted the dev_branch branch February 21, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gazeddy @fauxpark @zvecr @spidey3