-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added compaq keyboard and edited old keyboards stuff #11942
Conversation
got a dead keyboard for $8 and make it work with QMK with help of a teensy Keymap works great but haven't managed to make backlight work properly, but I still included the resistors connected to the LED you need to wire to
Made the firmware and the keymap through Keyboard Firmware Builder, didn't include the right shift, becaused it shared the circuit with the left one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does a lot more than the title suggests, and the description of the PR is rather sparse.
Can you please edit the title to reflect the actual changes, and provide more detail in the PR description?
Also, please add build instructions (or a link to them) into the keyboard-level |
Most changes are from a pull request that is already reviewed and merged, you can check this here |
Thanks for the suggestion, I'm planning on doing a blog or an album with comprehensive pictures, though right know I'm studying for my grade, so I don't have much time, I do however have pinouts and everything, so will upload them for sure :) |
Pinouts and a rough wiring diagram would be fine. Even if it's just a photo of a handwritten sketch... |
Can you update the change-request status please?, as I explained most changes are from a past pull-request that is already approved and merged. I'm new to Github and probably I didn't open the pull request as a normal update to a repository, sorry for that. |
done! thanks for the help! I'm completely new to Github and absolute null for coding, so I would have never guessed, but it worked, thanks a lot! :) |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
just added a readme.md to the default keymap
Issues Fixed or Closed by This PR
Checklist