Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added compaq keyboard and edited old keyboards stuff #11942

Closed
wants to merge 42 commits into from
Closed

added compaq keyboard and edited old keyboards stuff #11942

wants to merge 42 commits into from

Conversation

andresteare
Copy link

just added a readme.md to the default keymap

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

andresteare and others added 19 commits January 21, 2021 15:32
got a dead keyboard for $8 and make it work with QMK with help of a teensy

Keymap works great but haven't managed to make backlight work properly, but I still included the resistors connected to the LED you need to wire to
Made the firmware and the keymap through Keyboard Firmware Builder, didn't include the right shift, becaused it shared the circuit with the left one
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 17, 2021
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a lot more than the title suggests, and the description of the PR is rather sparse.

Can you please edit the title to reflect the actual changes, and provide more detail in the PR description?

@spidey3
Copy link
Contributor

spidey3 commented Feb 20, 2021

Also, please add build instructions (or a link to them) into the keyboard-level readme.md files, so that others will be able to do the same hardware-side conversion of their IBM keyboards as you did.

@andresteare
Copy link
Author

This does a lot more than the title suggests, and the description of the PR is rather sparse.

Can you please edit the title to reflect the actual changes, and provide more detail in the PR description?

Most changes are from a pull request that is already reviewed and merged, you can check this here

@andresteare
Copy link
Author

Also, please add build instructions (or a link to them) into the keyboard-level readme.md files, so that others will be able to do the same hardware-side conversion of their IBM keyboards as you did.

Thanks for the suggestion, I'm planning on doing a blog or an album with comprehensive pictures, though right know I'm studying for my grade, so I don't have much time, I do however have pinouts and everything, so will upload them for sure :)

@spidey3
Copy link
Contributor

spidey3 commented Feb 22, 2021

I do however have pinouts and everything, so will upload them for sure :)

Pinouts and a rough wiring diagram would be fine. Even if it's just a photo of a handwritten sketch...

@andresteare andresteare requested a review from spidey3 February 22, 2021 21:22
@andresteare
Copy link
Author

andresteare commented Feb 22, 2021

This does a lot more than the title suggests, and the description of the PR is rather sparse.

Can you please edit the title to reflect the actual changes, and provide more detail in the PR description?

Can you update the change-request status please?, as I explained most changes are from a past pull-request that is already approved and merged. I'm new to Github and probably I didn't open the pull request as a normal update to a repository, sorry for that.

@github-actions github-actions bot removed keyboard via Adds via keymap and/or updates keyboard for via support labels Mar 17, 2021
@andresteare
Copy link
Author

That's the issue with using the master branch, and reusing it.

correct me if I'm wrong, but the only commits that are new are:
da9dab6 and 37fcd42

If so, then it may be "easy" to fix. You should create a new branch first, just in case though.
But to fix it:

git remote add upstream https://github.com/qmk/qmk_firmware.git
git fetch upstream
git reset upstream/master --hard
git cherry-pick da9dab6 37fcd42
git push --force-with-lease

done! thanks for the help! I'm completely new to Github and absolute null for coding, so I would have never guessed, but it worked, thanks a lot! :)

@github-actions github-actions bot added keyboard via Adds via keymap and/or updates keyboard for via support labels Mar 25, 2021
keyboards/handwired/ibm_wheelwriter/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/oem_iso_fullsize/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/oem_iso_fullsize/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ibm_wheelwriter/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/ibm_wheelwriter/config.h Outdated Show resolved Hide resolved
andresteare and others added 17 commits March 25, 2021 19:05
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@andresteare andresteare changed the title Added readme.md to the default keymap added compaq keyboard and edited old keyboards stuff Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants