Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokyo Keyboard alix40 initial commit #11918

Merged
merged 25 commits into from
Feb 22, 2021
Merged

Tokyo Keyboard alix40 initial commit #11918

merged 25 commits into from
Feb 22, 2021

Conversation

quadcube
Copy link

@quadcube quadcube commented Feb 15, 2021

Description

  1. New keyboard vendor directory under tokyokeyboard
  2. Moved tokyo60 into new tokyokeyboard directory
  3. Added alix40 with BLE and VIA support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 15, 2021
@quadcube
Copy link
Author

@alvn alix40 PR

@quadcube
Copy link
Author

@fauxpark Hi, could you help me to review this pull request? Thanks!

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved tokyo60 into new tokyokeyboard directory

This change will have to go via develop and not directly to master, I suggest breaking it out into its own PR as to not slow down the rest of the changes.

keyboards/tokyokeyboard/alix40/alix40.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/alix40.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/config.h Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/readme.md Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team February 18, 2021 23:50
@quadcube
Copy link
Author

Moved tokyo60 into new tokyokeyboard directory

This change will have to go via develop and not directly to master, I suggest breaking it out into its own PR as to not slow down the rest of the changes.

I have removed tokyo60 folder relocation from this PR. Will open another PR via the develop branch. Thank you for the review and suggestions!

@quadcube quadcube requested review from zvecr and removed request for a team February 19, 2021 17:17
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a GPL2+ compatible license header to all of the c and h files?

For instance:

/* Copyright %YEAR% %YOUR_NAME%
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

keyboards/tokyokeyboard/alix40/config.h Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/config.h Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/readme.md Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/rules.mk Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/alix40.c Outdated Show resolved Hide resolved
keyboards/tokyokeyboard/alix40/config.h Outdated Show resolved Hide resolved
quadcube and others added 2 commits February 20, 2021 18:12
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna merged commit 37e14fd into qmk:master Feb 22, 2021
drashna added a commit to drashna/qmk_firmware that referenced this pull request Feb 23, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: QuadCube <quadcube@QuadCube-Mac-mini.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants