Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Idobo Keymap #11897

Merged
merged 8 commits into from
Feb 21, 2021
Merged

My Idobo Keymap #11897

merged 8 commits into from
Feb 21, 2021

Conversation

ifohancroft
Copy link
Contributor

@ifohancroft ifohancroft commented Feb 14, 2021 •
edited
Loading

Description

Just submitting my Idobo keymap for inclusion.

Types of Changes

  • Keymap/layout/userspace (addition or update)
  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ifohancroft
Copy link
Contributor Author

Done

@ifohancroft ifohancroft requested a review from spidey3 February 18, 2021 01:40
@spidey3 spidey3 requested a review from a team February 18, 2021 20:22
@ifohancroft ifohancroft requested a review from drashna February 19, 2021 11:56
@ifohancroft
Added a license header
8b08190 
Added a license header to config.h
@drashna
Copy link
Member

drashna commented Feb 21, 2021

Thanks!

@drashna drashna merged commit bb9316a into qmk:master Feb 21, 2021
@ifohancroft ifohancroft deleted the idobo branch February 21, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ifohancroft @drashna @fauxpark @spidey3