Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] NEO Keys Palette G67 Hotswap & Soldered #11850

Merged
merged 5 commits into from
Feb 14, 2021
Merged

[Keyboard] NEO Keys Palette G67 Hotswap & Soldered #11850

merged 5 commits into from
Feb 14, 2021

Conversation

noroadsleft
Copy link
Member

Description

[title]

Pulled from some KBFirmware JSON files after a Discord user contacted me about this board.

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 10, 2021
@noroadsleft noroadsleft requested review from mechmerlin and a team February 10, 2021 05:58
@noroadsleft noroadsleft mentioned this pull request Feb 10, 2021
Merged
6 tasks
@drashna
Copy link
Member

drashna commented Feb 13, 2021

neokeys/g67/soldered: LAYOUT_65_iso_blocker_tsangan: Number of elements in info.json does not match! info.json:66 != LAYOUT_65_iso_blocker_tsangan:67

@noroadsleft
fix info.json error
4eebb46 
Adds the Non-US Backslash key to LAYOUT_65_iso_blocker_tsangan's info.json data.
@drashna drashna merged commit d035bb5 into qmk:master Feb 14, 2021
@noroadsleft noroadsleft deleted the kb/neokeys_g67 branch February 14, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark