Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for YMD 75 #11811

Merged
merged 17 commits into from
Feb 16, 2021
Merged

Add VIA support for YMD 75 #11811

merged 17 commits into from
Feb 16, 2021

Conversation

kshpits
Copy link

@kshpits kshpits commented Feb 6, 2021 •
edited
Loading

Description

Add VIA support for YMD75 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Feb 6, 2021
drashna
drashna requested changes Feb 7, 2021
View reviewed changes
keyboards/ymd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ymd75/keymaps/via/keymap.c Show resolved Hide resolved
@kshpits kshpits requested a review from drashna February 7, 2021 20:08
@kshpits kshpits mentioned this pull request Feb 10, 2021
Merged
6 tasks
drashna
drashna approved these changes Feb 12, 2021
View reviewed changes
keyboards/ymd75/keymaps/via/config.h Outdated Show resolved Hide resolved
@drashna drashna self-requested a review February 12, 2021 03:01
@kshpits
Copy link
Author

kshpits commented Feb 12, 2021

Linter shows that readme.md for rev 1 board is missing.
Do i need to add it? Previous checks were ok without it.

@drashna
Copy link
Member

drashna commented Feb 12, 2021

I think it's fine.

@drashna drashna requested a review from a team February 12, 2021 23:17
fauxpark
fauxpark requested changes Feb 14, 2021
View reviewed changes
keyboards/ymd75/rev1/config.h Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the keyboard label Feb 15, 2021
fauxpark
fauxpark requested changes Feb 15, 2021
View reviewed changes
keyboards/ymd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ymd75/keymaps/via/config.h Outdated Show resolved Hide resolved
kshpits and others added 2 commits February 15, 2021 10:26
@kshpits kshpits requested a review from fauxpark February 15, 2021 06:28
@kshpits kshpits requested a review from fauxpark February 15, 2021 07:20
@fauxpark fauxpark requested a review from a team February 15, 2021 07:30
@kshpits kshpits requested review from fauxpark and removed request for a team February 16, 2021 14:10
@kshpits
Copy link
Author

kshpits commented Feb 16, 2021

Sorry for an accidentally request, thought it will go qmk/collaborators.

@fauxpark fauxpark requested a review from a team February 16, 2021 21:12
@fauxpark fauxpark requested a review from a team February 16, 2021 21:12
@drashna drashna merged commit bf3ee94 into qmk:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshpits @drashna @fauxpark