Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard: Quadrant by Ealdin #11747

Merged
merged 38 commits into from
Feb 19, 2021
Merged

New Keyboard: Quadrant by Ealdin #11747

merged 38 commits into from
Feb 19, 2021

Conversation

nuno99costa
Copy link

@nuno99costa nuno99costa commented Jan 31, 2021

Description

Quadrant by Ealdin. This is my first pull request. Hopefully I did it right.

Original Github Repo for this keyboard
Code written by @Ealdin and tested by me. Includes:

  • VIA Support
  • Default layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 31, 2021
@nuno99costa
Copy link
Author

Fixed error with the encoder support on the board (seemed to be based on a previous release of QMK), tested both the default and VIA keymaps and both seem to work now.

keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/quadrant.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/quadrant.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
nuno99costa and others added 9 commits February 5, 2021 18:24
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@nuno99costa
Copy link
Author

Thanks @drashna for the suggestions I will apply them and test on my board and report back if it works well!

@nuno99costa
Copy link
Author

Finished testing, VIA and default keymap works. Ended up having to fix a couple brackets and layout names. Thanks once again for the help @drashna !

@nuno99costa
Copy link
Author

nuno99costa commented Feb 6, 2021

The changes suggested by @drashna ended up breaking the default keymap. I talked with the pcb designer for this and found out the matrix layout is inverted. As such, the layout mapping in quadrant.h has to be altered and "non standard" to support this keyboard.

Shoutout to @Ealdin for helping me fix these issues.

keyboards/ealdin/readme.md Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Feb 12, 2021

Using the LED_CAPS_LOCK_PIN definition doesn't work, for some reason, with this board. After testing, I updated the code to use one of the other methods defined in the qmk documentation (led_update_kb function).

You may need #define LED_PIN_ON_STATE 0 as well.

@nuno99costa
Copy link
Author

nuno99costa commented Feb 12, 2021

Using the LED_CAPS_LOCK_PIN definition doesn't work, for some reason, with this board. After testing, I updated the code to use one of the other methods defined in the qmk documentation (led_update_kb function).

You may need #define LED_PIN_ON_STATE 0 as well.

I will try this and will update if it works that way. (I would also prefer these simple definitions instead of the "bulkier" functions).

@drashna drashna requested a review from a team February 12, 2021 22:55
@nuno99costa
Copy link
Author

The #define LED_PIN_ON_STATE 0 didn't work out. The current code is using a current suggested implementation and as such is in accordance with QMK guidelines. As such , I believe we can go ahead with the pull request.

keyboards/ealdin/quadrant/rules.mk Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/rules.mk Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/keymaps/default/keymap.c Outdated Show resolved Hide resolved
nuno99costa and others added 9 commits February 16, 2021 15:40
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@nuno99costa
Copy link
Author

Updates from @fauxpark added

@nuno99costa nuno99costa requested a review from fauxpark February 16, 2021 15:53
keyboards/ealdin/quadrant/readme.md Outdated Show resolved Hide resolved
keyboards/ealdin/quadrant/readme.md Outdated Show resolved Hide resolved
nuno99costa and others added 3 commits February 18, 2021 01:17
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@nuno99costa nuno99costa requested a review from zvecr February 18, 2021 01:19
@nuno99costa
Copy link
Author

Can't understand the issues on the travis-ci build (seems to be trying to build a community layout)

@drashna
Copy link
Member

drashna commented Feb 19, 2021

That's fine. Community layouts sometimes error out.

@drashna drashna merged commit 307c974 into qmk:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants