-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Keyboard: Quadrant by Ealdin #11747
Conversation
Fixed error with the encoder support on the board (seemed to be based on a previous release of QMK), tested both the default and VIA keymaps and both seem to work now. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Thanks @drashna for the suggestions I will apply them and test on my board and report back if it works well! |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Finished testing, VIA and default keymap works. Ended up having to fix a couple brackets and layout names. Thanks once again for the help @drashna ! |
The changes suggested by @drashna ended up breaking the default keymap. I talked with the pcb designer for this and found out the matrix layout is inverted. As such, the layout mapping in quadrant.h has to be altered and "non standard" to support this keyboard. Shoutout to @Ealdin for helping me fix these issues. |
You may need |
I will try this and will update if it works that way. (I would also prefer these simple definitions instead of the "bulkier" functions). |
The |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Updates from @fauxpark added |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Can't understand the issues on the travis-ci build (seems to be trying to build a community layout) |
That's fine. Community layouts sometimes error out. |
Description
Quadrant by Ealdin. This is my first pull request. Hopefully I did it right.
Original Github Repo for this keyboard
Code written by @Ealdin and tested by me. Includes:
Types of Changes
Checklist